Skip to content

Commit f510bc7

Browse files
committed
[lldb-mi] Remove use of dialog box
Summary: This really is only implemented on Windows, and it requires us to pull in User32. This was only useful when debugging on lldb-mi on Windows, and there doesn't seem to be a good reason why using a dialog box is better than what exists for other platforms. Reviewers: zturner, jingham, compnerd Subscribers: ki.stfu Differential Revision: https://reviews.llvm.org/D56755 llvm-svn: 351276
1 parent 34ac509 commit f510bc7

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

lldb/tools/lldb-mi/MIDriverMain.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,7 @@ bool DriverSystemShutdown(const bool vbAppExitOk) {
165165
//--
166166
int main(int argc, char const *argv[]) {
167167
#if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
168-
#ifdef _WIN32
169-
CMIUtilDebug::ShowDlgWaitForDbgAttach();
170-
#else
171168
CMIUtilDebug::WaitForDbgAttachInfinteLoop();
172-
#endif // _WIN32
173169
#endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
174170

175171
llvm::StringRef ToolName = argv[0];

lldb/tools/lldb-mi/MIUtilDebug.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -37,25 +37,6 @@ CMIUtilDebug::CMIUtilDebug() {}
3737
//--
3838
CMIUtilDebug::~CMIUtilDebug() {}
3939

40-
//++
41-
//------------------------------------------------------------------------------------
42-
// Details: Show a dialog to the process/application halts. It gives the
43-
// opportunity to
44-
// attach a debugger.
45-
// Type: Static method.
46-
// Args: None.
47-
// Return: None.
48-
// Throws: None.
49-
//--
50-
void CMIUtilDebug::ShowDlgWaitForDbgAttach() {
51-
const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort());
52-
#ifdef _WIN32
53-
::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK);
54-
#else
55-
// ToDo: Implement other platform version of an Ok to continue dialog box
56-
#endif // _WIN32
57-
}
58-
5940
//++
6041
//------------------------------------------------------------------------------------
6142
// Details: Temporarily stall the process/application to give the programmer the

lldb/tools/lldb-mi/MIUtilDebug.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ class CMICmnLog;
2424
class CMIUtilDebug {
2525
// Statics:
2626
public:
27-
static void ShowDlgWaitForDbgAttach();
2827
static void WaitForDbgAttachInfinteLoop();
2928

3029
// Methods:

0 commit comments

Comments
 (0)