[beta] backport libgit2 #8780
Merged
[beta] backport libgit2 #8780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update git2. Closes rust-lang#8517 Closes rust-lang#8588 Closes rust-lang#8352 Closes rust-lang#4777 Closes rust-lang#8746 I only added a test for one of these. I can add for the others if you want.
Update toml dependency
| r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive added the S-waiting-on-review 
Member
| @bors: r+ Nah I think this is a good idea to backport for all the fixes, and we should have some time before shipping anyway to weed out any other issues. |
Contributor
| 📌 Commit bb66e0f has been approved by |
bors added S-waiting-on-bors Contributor
Contributor
| ☀️ Test successful - checks-actions |
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2020
…acrum [beta] Update cargo 1 commits in 75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2..65cbdd2dc0b7e877577474b98b7d071308d0bb6f 2020-09-29 18:42:19 +0000 to 2020-10-14 16:10:15 +0000 - [beta] backport libgit2 (rust-lang/cargo#8780) This is primarily to bring in a fix for rust-lang/cargo#8517 which is starting to show up on rust-lang/rust's CI again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a backport of #8778 to beta. The reason is that #8517 has started showing up again on rust-lang/rust CI, and I think it is important to fix that.
This is risky, because this is a large update with a lot of untested changes. However, I think the risk is worth it to fix #8517.
This also includes #8772 to get Cargo's CI to pass. I think the risk for that is low (the changes are small). However, I'd be fine with just modifying the tests to pass if you want to drop it.