Skip to content

Conversation

@japaric
Copy link
Member

@japaric japaric commented Sep 23, 2018

This PR depends on #24

r? @rust-embedded/resources
@jamesmunns this is the global singleton pattern I mentioned some time ago on
IRC

@japaric japaric requested a review from a team as a code owner September 23, 2018 23:47
@japaric
Copy link
Member Author

japaric commented Sep 24, 2018

This has been rebased and it's ready for review.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 24, 2018
25: Global singletons r=therealprof a=japaric This PR depends on #24 r? @rust-embedded/resources @jamesmunns this is the global singleton pattern I mentioned some time ago on IRC Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Sep 24, 2018

@bors bors bot merged commit ba1ceb2 into master Sep 24, 2018
@bors bors bot deleted the singleton branch September 24, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants