Skip to content

Commit 531c2bc

Browse files
committed
Drop ReactDOM from internal DOM extensions
These used to be exposed as strings on the legacy factories but are now gone.
1 parent 581085e commit 531c2bc

File tree

7 files changed

+7
-21
lines changed

7 files changed

+7
-21
lines changed

src/browser/ui/dom/components/ReactDOMButton.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ var AutoFocusMixin = require('AutoFocusMixin');
1515
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1616
var ReactClass = require('ReactClass');
1717
var ReactElement = require('ReactElement');
18-
var ReactDOM = require('ReactDOM');
1918

2019
var keyMirror = require('keyMirror');
2120

22-
// Store a reference to the <button> `ReactDOMComponent`. TODO: use string
23-
var button = ReactElement.createFactory(ReactDOM.button.type);
21+
var button = ReactElement.createFactory('button');
2422

2523
var mouseListenerNames = keyMirror({
2624
onClick: true,

src/browser/ui/dom/components/ReactDOMForm.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@ var LocalEventTrapMixin = require('LocalEventTrapMixin');
1616
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1717
var ReactClass = require('ReactClass');
1818
var ReactElement = require('ReactElement');
19-
var ReactDOM = require('ReactDOM');
2019

21-
// Store a reference to the <form> `ReactDOMComponent`. TODO: use string
22-
var form = ReactElement.createFactory(ReactDOM.form.type);
20+
var form = ReactElement.createFactory('form');
2321

2422
/**
2523
* Since onSubmit doesn't bubble OR capture on the top level in IE8, we need

src/browser/ui/dom/components/ReactDOMImg.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@ var LocalEventTrapMixin = require('LocalEventTrapMixin');
1616
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1717
var ReactClass = require('ReactClass');
1818
var ReactElement = require('ReactElement');
19-
var ReactDOM = require('ReactDOM');
2019

21-
// Store a reference to the <img> `ReactDOMComponent`. TODO: use string
22-
var img = ReactElement.createFactory(ReactDOM.img.type);
20+
var img = ReactElement.createFactory('img');
2321

2422
/**
2523
* Since onLoad doesn't bubble OR capture on the top level in IE8, we need to

src/browser/ui/dom/components/ReactDOMInput.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@ var LinkedValueUtils = require('LinkedValueUtils');
1717
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1818
var ReactClass = require('ReactClass');
1919
var ReactElement = require('ReactElement');
20-
var ReactDOM = require('ReactDOM');
2120
var ReactMount = require('ReactMount');
2221
var ReactUpdates = require('ReactUpdates');
2322

2423
var assign = require('Object.assign');
2524
var invariant = require('invariant');
2625

27-
// Store a reference to the <input> `ReactDOMComponent`. TODO: use string
28-
var input = ReactElement.createFactory(ReactDOM.input.type);
26+
var input = ReactElement.createFactory('input');
2927

3028
var instancesByReactID = {};
3129

src/browser/ui/dom/components/ReactDOMOption.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@
1414
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1515
var ReactClass = require('ReactClass');
1616
var ReactElement = require('ReactElement');
17-
var ReactDOM = require('ReactDOM');
1817

1918
var warning = require('warning');
2019

21-
// Store a reference to the <option> `ReactDOMComponent`. TODO: use string
22-
var option = ReactElement.createFactory(ReactDOM.option.type);
20+
var option = ReactElement.createFactory('option');
2321

2422
/**
2523
* Implements an <option> native component that warns when `selected` is set.

src/browser/ui/dom/components/ReactDOMSelect.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@ var LinkedValueUtils = require('LinkedValueUtils');
1616
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1717
var ReactClass = require('ReactClass');
1818
var ReactElement = require('ReactElement');
19-
var ReactDOM = require('ReactDOM');
2019
var ReactUpdates = require('ReactUpdates');
2120

2221
var assign = require('Object.assign');
2322

24-
// Store a reference to the <select> `ReactDOMComponent`. TODO: use string
25-
var select = ReactElement.createFactory(ReactDOM.select.type);
23+
var select = ReactElement.createFactory('select');
2624

2725
function updateWithPendingValueIfMounted() {
2826
/*jshint validthis:true */

src/browser/ui/dom/components/ReactDOMTextarea.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,14 @@ var LinkedValueUtils = require('LinkedValueUtils');
1717
var ReactBrowserComponentMixin = require('ReactBrowserComponentMixin');
1818
var ReactClass = require('ReactClass');
1919
var ReactElement = require('ReactElement');
20-
var ReactDOM = require('ReactDOM');
2120
var ReactUpdates = require('ReactUpdates');
2221

2322
var assign = require('Object.assign');
2423
var invariant = require('invariant');
2524

2625
var warning = require('warning');
2726

28-
// Store a reference to the <textarea> `ReactDOMComponent`. TODO: use string
29-
var textarea = ReactElement.createFactory(ReactDOM.textarea.type);
27+
var textarea = ReactElement.createFactory('textarea');
3028

3129
function forceUpdateIfMounted() {
3230
/*jshint validthis:true */

0 commit comments

Comments
 (0)