util/rubocop -A --only Style/NegatedIf

Author: hsbt

.rubocop.yml

@@ -441,6 +441,9 @@ Security/Open:
 Security/JSONLoad:
  Enabled: true
 
+Style/NegatedIf:
+ Enabled: true
+
 Style/ColonMethodCall:
  Enabled: true
 

.rubocop_bundler.yml

@@ -136,9 +136,6 @@ Style/MultilineTernaryOperator:
 Style/MultipleComparison:
  Enabled: true
 
-Style/NegatedIf:
- Enabled: true
-
 Style/NestedModifier:
  Enabled: true
 

lib/rubygems/commands/cert_command.rb

@@ -135,7 +135,7 @@ def execute
  end
 
  def build(email)
- if !valid_email?(email)
+ unless valid_email?(email)
  raise Gem::CommandLineError, "Invalid email address #{email}"
  end
 

lib/rubygems/query_utils.rb

@@ -84,7 +84,7 @@ def check_installed_gems(gem_names)
  installed = !installed unless options[:installed]
 
  say(installed)
- exit_code = 1 if !installed
+ exit_code = 1 unless installed
  end
 
  exit_code

lib/rubygems/source.rb

@@ -44,12 +44,12 @@ def <=>(other)
  Gem::Source::Vendor then
  -1
  when Gem::Source then
- if !@uri
+ unless @uri
  return 0 unless other.uri
  return 1
  end
 
- return -1 if !other.uri
+ return -1 unless other.uri
 
  # Returning 1 here ensures that when sorting a list of sources, the
  # original ordering of sources supplied by the user is preserved.

lib/rubygems/specification.rb

@@ -1616,8 +1616,8 @@ def build_extensions # :nodoc:
  # we need to fresh build when same name and version of default gems
  return if self.class.find_by_full_name(full_name)&.default_gem?
  return if File.exist? gem_build_complete_path
- return if !File.writable?(base_dir)
- return if !File.exist?(File.join(base_dir, "extensions"))
+ return unless File.writable?(base_dir)
+ return unless File.exist?(File.join(base_dir, "extensions"))
 
  begin
  # We need to require things in $LOAD_PATH without looking for the

lib/rubygems/specification_policy.rb

@@ -125,15 +125,15 @@ def validate_metadata
 
  metadata.each do |key, value|
  entry = "metadata['#{key}']"
- if !key.is_a?(String)
+ unless key.is_a?(String)
  error "metadata keys must be a String"
  end
 
  if key.size > 128
  error "metadata key is too large (#{key.size} > 128)"
  end
 
- if !value.is_a?(String)
+ unless value.is_a?(String)
  error "#{entry} value must be a String"
  end
 
@@ -368,7 +368,7 @@ def validate_licenses
  licenses = @specification.licenses
 
  licenses.each do |license|
- if !Gem::Licenses.match?(license)
+ unless Gem::Licenses.match?(license)
  suggestions = Gem::Licenses.suggestions(license)
  message = <<-WARNING
 license value '#{license}' is invalid. Use a license identifier from

lib/rubygems/user_interaction.rb

@@ -281,7 +281,7 @@ def ask_yes_no(question, default=nil)
  # Ask a question. Returns an answer if connected to a tty, nil otherwise.
 
  def ask(question)
- return nil if !tty?
+ return nil unless tty?
 
  @outs.print(question + " ")
  @outs.flush
@@ -295,7 +295,7 @@ def ask(question)
  # Ask for a password. Does not echo response to terminal.
 
  def ask_for_password(question)
- return nil if !tty?
+ return nil unless tty?
 
  @outs.print(question, " ")
  @outs.flush

test/rubygems/test_gem_requirement.rb

@@ -83,7 +83,7 @@ def test_parse
  Gem::Requirement.parse(Gem::Version.new("2"))
  end
 
- if !(Gem.java_platform? && ENV["JRUBY_OPTS"].to_s.include?("--debug"))
+ unless (Gem.java_platform? && ENV["JRUBY_OPTS"].to_s.include?("--debug"))
  def test_parse_deduplication
  assert_same "~>", Gem::Requirement.parse("~> 1").first
  end