Implement show-all-if-ambiguous feature #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tompng reviewed Apr 17, 2024
lib/reline/line_editor.rb Outdated
| @perfect_matched = completed | ||
| else | ||
| @completion_state = CompletionState::MENU | ||
| complete(list, just_show_list) if @config.show_all_if_ambiguous |
Member
There was a problem hiding this comment.
I think the flow is complex because complete became a recursive method.
How about complete_internal_proc(list, true)
Member Author
There was a problem hiding this comment.
Since complete_internal_proc does not change the state of @completion_state, it did not fit this purpose. I decided to call it complete(list, true).
Member
| Looks like this case is missing: |
ima1zumi force-pushed the show-all-if-ambiguous branch from 93df93e to 84ad9fa Compare tompng approved these changes Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This feature displays all possible completions with a single tab press if autocomplete is disabled and multiple completions are available. It does not alter behavior when autocomplete is enabled.
https://tiswww.case.edu/php/chet/readline/readline.html
To use this feature, add these lines to your
.inputrcfile and startirbwith--noautocomplete: