Skip to content

Conversation

@ima1zumi
Copy link
Member

@ima1zumi
Copy link
Member Author

irb head has failed

Failure: test_autocomplete_with_showdoc_in_gaps_on_narrow_screen_left(IRB::RenderingTest::TestVTerm) /home/runner/.rubies/ruby-head/lib/ruby/gems/3.4.0+0/bundler/gems/yamatanooroti-ec2ccedaf90e/lib/yamatanooroti/vterm.rb:114:in 'Yamatanooroti::VTermTestCaseModule#assert_screen' /home/runner/work/reline/reline/irb/test/irb/yamatanooroti/test_rendering.rb:319:in 'IRB::RenderingTest::TestVTerm#test_autocomplete_with_showdoc_in_gaps_on_narrow_screen_left' <"start IRB\n" + "001> IRB\n" + "PressIRB\n" + "IRB\n"> expected but was <"start IRB\n" + "001> IR\n" + " IRB\n"> diff: start IRB ? 001> IRB - PressIRB ? IRB Failure: test_autocomplete_with_showdoc_in_gaps_on_narrow_screen_right(IRB::RenderingTest::TestVTerm) /home/runner/.rubies/ruby-head/lib/ruby/gems/3.4.0+0/bundler/gems/yamatanooroti-ec2ccedaf90e/lib/yamatanooroti/vterm.rb:114:in 'Yamatanooroti::VTermTestCaseModule#assert_screen' /home/runner/work/reline/reline/irb/test/irb/yamatanooroti/test_rendering.rb:293:in 'IRB::RenderingTest::TestVTerm#test_autocomplete_with_showdoc_in_gaps_on_narrow_screen_right' <"start IRB\n" + "001> IRB\n" + " IRBPress Alt+\n" + " IRB\n"> expected but was <"start IRB\n" + "001> IR\n" + " IRB\n"> diff: start IRB ? 001> IRB - IRBPress Alt+ ? IRB 
@tompng
Copy link
Member

tompng commented Mar 25, 2024

I think ruby/irb#911 will fix test failure
I think master branch passes the test because master with irb is not using latest reline (the job log includes Installing reline 0.4.3) probably because version string includes suffix .pre.1

@ima1zumi ima1zumi merged commit 1d65696 into ruby:master Mar 25, 2024
@ima1zumi ima1zumi deleted the bump-0.5.0 branch March 25, 2024 12:13
matzbot pushed a commit to ruby/ruby that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants