Decouple RubyLex from prompt and line_no #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tompng force-pushed the stateless_rubylex branch from a9744da to ec52279 Compare 
tompng force-pushed the stateless_rubylex branch from ec52279 to f1aef4a Compare 
st0012 reviewed Oct 11, 2023
Member
st0012 left a comment
st0012 left a comment There was a problem hiding this comment.
Currently we don't declare private methods under IRB::Irb, but I think these 2 prompt methods can be the first 2. WDYT?
While we expect Irb to be a private component, it's still relatively easy to retrieve (e.g. with irb_context.irb) and could be used by us in other gems too (e.g. ruby/debug#1024). So making some methods private could ideally make people think twice before calling them.
st0012 approved these changes Oct 11, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 12, 2023
(ruby/irb#701) * Remove instance variable prompt and line_no from RubyLex * Fix prompt test * Rename prompt generating method and make it private ruby/irb@1ceb97fe2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removes the last RubyLex's instance variable
@promptand@line_no.Reason:
@line_nois completely controlled by IRB::Irb with@scanner.increase_line_no. It should be IRB::Irb's instance variable.@scanner.set_prompt do endand@scanner.prompt(args)seems roundabout.I wanted to remove
save_prompt_to_context_iobecause the flow is complex and hard to understand.After deleting
@promptand@line_nofrom RubyLex, RubyLex will have no state at all. RubyLex does not have to be a class anymore.