Skip to content

Conversation

@rm155
Copy link

@rm155 rm155 commented Aug 18, 2021

By freezing constants and moving from class variables to Ractor-local storage, error-highlight can improve its ability to be used within Ractors.

@mame mame requested a review from ko1 August 29, 2021 15:18
@mame
Copy link
Member

mame commented Oct 20, 2021

Thanks. I'm waiting for @ko1's review.

FYI: There is another report for this issue. https://bugs.ruby-lang.org/issues/18130

@mame
Copy link
Member

mame commented Oct 27, 2021

Oops! I talked with @ko1 and @yuki24 (the author of DidYouMean) about the ractor support of the formatter mechanism, and have pushed my commit. I forgot this PR but eventually the change was almost the same. I should have merge this PR. I'm sorry but let me close this PR. Thank you.

@mame mame closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants