Skip to content

Conversation

@braktar
Copy link
Contributor

@braktar braktar commented Sep 30, 2025

Relative to the discussions from #2608

All comments are welcome

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to include more of that example that @ericproulx wrote of how to make an endpoint instance?

README.md Outdated
* **[AppSignal](https://www.appsignal.com)** - [appsignal-ruby](https://github.com/appsignal/appsignal-ruby) gem, [documentation](http://docs.appsignal.com/getting-started/supported-frameworks.html#grape)
* **[ElasticAPM](https://www.elastic.co/products/apm)** - [elastic-apm](https://github.com/elastic/apm-agent-ruby) gem, [documentation](https://www.elastic.co/guide/en/apm/agent/ruby/3.x/getting-started-rack.html#getting-started-grape)
* **[Datadog APM](https://docs.datadoghq.com/tracing/)** - [ddtrace](https://github.com/datadog/dd-trace-rb) gem, [documentation](https://docs.datadoghq.com/tracing/setup_overview/setup/ruby/#grape)
* **Rails Performance** - **[rails_performance](https://github.com/igorkasyanchuk/rails_performance) gem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there docs? Can we make it look like other lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, there is no doc except the project README

@braktar
Copy link
Contributor Author

braktar commented Sep 30, 2025

Would you like to have the entire @ericproulx example in the README to illustrate ? Or only key points ?

@dblock
Copy link
Member

dblock commented Sep 30, 2025

Would you like to have the entire @ericproulx example in the README to illustrate ? Or only key points ?

I like something minimal and illustrative that works ;)

@braktar
Copy link
Contributor Author

braktar commented Oct 1, 2025

@dblock Tell me what you think of this one

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just some more nits, please? Sorry to be annoying.

@braktar
Copy link
Contributor Author

braktar commented Oct 2, 2025

Thank you for taking the time to refine 🙏

@dblock dblock merged commit 8fbed0d into ruby-grape:master Oct 2, 2025
102 of 103 checks passed
@dblock
Copy link
Member

dblock commented Oct 2, 2025

Thanks for taking the time to do this @braktar!

@braktar braktar deleted the hook-readme branch October 3, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants