-
- Notifications
You must be signed in to change notification settings - Fork 1.2k
Hook readme #2609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook readme #2609
Conversation
cb92972 to 841f53f Compare
dblock left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to include more of that example that @ericproulx wrote of how to make an endpoint instance?
README.md Outdated
| * **[AppSignal](https://www.appsignal.com)** - [appsignal-ruby](https://github.com/appsignal/appsignal-ruby) gem, [documentation](http://docs.appsignal.com/getting-started/supported-frameworks.html#grape) | ||
| * **[ElasticAPM](https://www.elastic.co/products/apm)** - [elastic-apm](https://github.com/elastic/apm-agent-ruby) gem, [documentation](https://www.elastic.co/guide/en/apm/agent/ruby/3.x/getting-started-rack.html#getting-started-grape) | ||
| * **[Datadog APM](https://docs.datadoghq.com/tracing/)** - [ddtrace](https://github.com/datadog/dd-trace-rb) gem, [documentation](https://docs.datadoghq.com/tracing/setup_overview/setup/ruby/#grape) | ||
| * **Rails Performance** - **[rails_performance](https://github.com/igorkasyanchuk/rails_performance) gem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there docs? Can we make it look like other lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, there is no doc except the project README
| Would you like to have the entire @ericproulx example in the README to illustrate ? Or only key points ? |
I like something minimal and illustrative that works ;) |
| @dblock Tell me what you think of this one |
dblock left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, just some more nits, please? Sorry to be annoying.
| Thank you for taking the time to refine 🙏 |
| Thanks for taking the time to do this @braktar! |
Relative to the discussions from #2608
All comments are welcome