Renamed GrapeEntity to Grape::Entity. #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I am a little concerned moving
Grape::Entityinto a new namespaceGrapeEntity::Entity, it will force people to update a lot of stuff. And I think there's no real good reason not to keep entities inside theGrapenamespace.There's a collision on
Grape::VERSION, so I left that one alone asGrapeEntity::VERSION.I think I have fixed .gemspec with all the correct runtime dependencies, but we need to port a lot of the test code that lives behind Grape API in here, such as for
to_xml.