Merge pull request #1522 from Earlopain/find-by-where-block

Fix an error for `Rails/FindBy` when `where` takes a block

Author: koic

changelog/fix_error_find_by_block.md

@@ -0,0 +1 @@
+* [#1522](https://github.com/rubocop/rubocop-rails/pull/1522): Fix an error for `Rails/FindBy` when `where` takes a block. ([@earlopain][])

lib/rubocop/cop/rails/find_by.rb

@@ -46,7 +46,7 @@ def on_send(node)
  private
 
  def where_method?(receiver)
- return false unless receiver
+ return false if !receiver || receiver.any_block_type?
 
  receiver.respond_to?(:method?) && receiver.method?(:where)
  end

spec/rubocop/cop/rails/find_by_spec.rb

@@ -103,6 +103,12 @@
  RUBY
  end
 
+ it 'does not register an offense when where takes a block' do
+ expect_no_offenses(<<~RUBY)
+ where { foo }.take
+ RUBY
+ end
+
  context 'when `IgnoreWhereFirst: true' do
  let(:cop_config) do
  { 'IgnoreWhereFirst' => true }