Cut 2.33.0

Author: koic

CHANGELOG.md

@@ -9,6 +9,8 @@
 
 ## master (unreleased)
 
+## 2.33.0 (2025-08-10)
+
 ### New features
 
 * [#1324](https://github.com/rubocop/rubocop-rails/pull/1324): Add `Rails/FindByOrAssignmentMemoization` cop. ([@r7kamura][])

config/default.yml

@@ -544,7 +544,7 @@ Rails/FindByOrAssignmentMemoization:
  StyleGuide: 'https://rails.rubystyle.guide/#find-by-memoization'
  Enabled: pending
  Safe: false
- VersionAdded: '<<next>>'
+ VersionAdded: '2.33'
 
 Rails/FindEach:
  Description: 'Prefer all.find_each over all.each.'
@@ -663,7 +663,7 @@ Rails/IndexWith:
  Enabled: true
  SafeAutoCorrect: false
  VersionAdded: '2.5'
- VersionChanged: '<<next>>'
+ VersionChanged: '2.33'
 
 Rails/Inquiry:
  Description: "Prefer Ruby's comparison operators over Active Support's `Array#inquiry` and `String#inquiry`."
@@ -761,7 +761,7 @@ Rails/OrderArguments:
  Description: 'Prefer symbol arguments over strings in `order` method.'
  StyleGuide: 'https://rails.rubystyle.guide/#order-arguments'
  Enabled: pending
- VersionAdded: '<<next>>'
+ VersionAdded: '2.33'
  Safe: false
 
 Rails/OrderById:

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-rails
 title: RuboCop Rails
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: ~
+version: '2.33'
 nav:
  - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops.adoc

@@ -63,6 +63,7 @@ based on the https://rails.rubystyle.guide/[Rails Style Guide].
 * xref:cops_rails.adoc#railsfilepath[Rails/FilePath]
 * xref:cops_rails.adoc#railsfindby[Rails/FindBy]
 * xref:cops_rails.adoc#railsfindbyid[Rails/FindById]
+* xref:cops_rails.adoc#railsfindbyorassignmentmemoization[Rails/FindByOrAssignmentMemoization]
 * xref:cops_rails.adoc#railsfindeach[Rails/FindEach]
 * xref:cops_rails.adoc#railsfreezetime[Rails/FreezeTime]
 * xref:cops_rails.adoc#railshasandbelongstomany[Rails/HasAndBelongsToMany]
@@ -87,6 +88,7 @@ based on the https://rails.rubystyle.guide/[Rails Style Guide].
 * xref:cops_rails.adoc#railsmultipleroutepaths[Rails/MultipleRoutePaths]
 * xref:cops_rails.adoc#railsnegateinclude[Rails/NegateInclude]
 * xref:cops_rails.adoc#railsnotnullcolumn[Rails/NotNullColumn]
+* xref:cops_rails.adoc#railsorderarguments[Rails/OrderArguments]
 * xref:cops_rails.adoc#railsorderbyid[Rails/OrderById]
 * xref:cops_rails.adoc#railsoutput[Rails/Output]
 * xref:cops_rails.adoc#railsoutputsafety[Rails/OutputSafety]

docs/modules/ROOT/pages/cops_rails.adoc

@@ -2124,7 +2124,7 @@ enum :status, { active: 0, archived: 1 }, prefix: true
 | String
 
 | Include
-| `+**/app/models/**/*.rb+`
+| `+**/app/models/**/*.rb+`, `+**/lib/**/*.rb+`
 | Array
 |===
 
@@ -2608,6 +2608,55 @@ User.find(id)
 
 * https://rails.rubystyle.guide/#find
 
+[#railsfindbyorassignmentmemoization]
+== Rails/FindByOrAssignmentMemoization
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| No
+| Always (Unsafe)
+| 2.33
+| -
+|===
+
+Avoid memoizing `find_by` results with `||=`.
+
+It is common to see code that attempts to memoize `find_by` result by `||=`,
+but `find_by` may return `nil`, in which case it is not memoized as intended.
+
+[#safety-railsfindbyorassignmentmemoization]
+=== Safety
+
+This cop is unsafe because detected `find_by` may not be Active Record's method,
+or the code may have a different purpose than memoization.
+
+[#examples-railsfindbyorassignmentmemoization]
+=== Examples
+
+[source,ruby]
+----
+# bad
+def current_user
+ @current_user ||= User.find_by(id: session[:user_id])
+end
+
+# good
+def current_user
+ if instance_variable_defined?(:@current_user)
+ @current_user
+ else
+ @current_user = User.find_by(id: session[:user_id])
+ end
+end
+----
+
+[#references-railsfindbyorassignmentmemoization]
+=== References
+
+* https://rails.rubystyle.guide/#find-by-memoization
+
 [#railsfindeach]
 == Rails/FindEach
 
@@ -3409,16 +3458,23 @@ NOTE: Required Rails version: 6.0
 
 | Enabled
 | Yes
-| Always
+| Always (Unsafe)
 | 2.5
-| 2.8
+| 2.33
 |===
 
 Looks for uses of `each_with_object({}) { ... }`,
 `map { ... }.to_h`, and `Hash[map { ... }]` that are transforming
 an enumerable into a hash where the keys are the original elements.
 Rails provides the `index_with` method for this purpose.
 
+[#safety-railsindexwith]
+=== Safety
+
+This cop is marked as unsafe autocorrection, because `nil.to_h` returns {}
+but `nil.with_index` throws `NoMethodError`. Therefore, autocorrection is not
+compatible if the receiver is nil.
+
 [#examples-railsindexwith]
 === Examples
 
@@ -4139,6 +4195,45 @@ change_column_null :products, :category_id, false
 | Array
 |===
 
+[#railsorderarguments]
+== Rails/OrderArguments
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| No
+| Always (Unsafe)
+| 2.33
+| -
+|===
+
+Prefer symbol arguments over strings in `order` method.
+
+[#safety-railsorderarguments]
+=== Safety
+
+Cop is unsafe because the receiver might not be an Active Record query.
+
+[#examples-railsorderarguments]
+=== Examples
+
+[source,ruby]
+----
+# bad
+User.order('name')
+User.order('name DESC')
+
+# good
+User.order(:name)
+User.order(name: :desc)
+----
+
+[#references-railsorderarguments]
+=== References
+
+* https://rails.rubystyle.guide/#order-arguments
+
 [#railsorderbyid]
 == Rails/OrderById
 
@@ -4395,6 +4490,9 @@ users = User.all
 end
 ----
 
+If a method call has no receiver, like `do_something { users.map { |user| user[:foo] }`,
+it is not considered part of an iteration and will be detected.
+
 [#safety-railspluck]
 === Safety
 
@@ -6902,7 +7000,7 @@ Time.at(timestamp).in_time_zone
 === References
 
 * https://rails.rubystyle.guide#time
-* http://danilenko.org/2012/7/6/rails_timezones
+* https://danilenko.org/2012/7/6/rails_timezones
 
 [#railstimezoneassignment]
 == Rails/TimeZoneAssignment

lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
  module Rails
  # This module holds the RuboCop Rails version information.
  module Version
- STRING = '2.32.0'
+ STRING = '2.33.0'
 
  def self.document_version
  STRING.match('\d+\.\d+').to_s

relnotes/v2.33.0.md

@@ -0,0 +1,25 @@
+### New features
+
+* [#1324](https://github.com/rubocop/rubocop-rails/pull/1324): Add `Rails/FindByOrAssignmentMemoization` cop. ([@r7kamura][])
+* [#1501](https://github.com/rubocop/rubocop-rails/pull/1501): Add new cop `Rails/OrderArguments`. ([@lovro-bikic][])
+
+### Bug fixes
+
+* [#1497](https://github.com/rubocop/rubocop-rails/pull/1497): Fix bugs in `Rails/PluckId` and `Rails/PluckInWhere`. ([@r7kamura][])
+* [#1478](https://github.com/rubocop/rubocop-rails/issues/1478): Fix a false negative for `Rails/EnvLocal` when having preceding conditions. ([@fatkodima][])
+* [#1505](https://github.com/rubocop/rubocop-rails/issues/1505): Fix false negatives for `Rails/Pluck` when `map` method call is used in a block without a receiver. ([@koic][])
+* [#1486](https://github.com/rubocop/rubocop-rails/issues/1486): Fix false positives for `Rails/Output` when `p` method is a DSL. ([@koic][])
+* [#1495](https://github.com/rubocop/rubocop-rails/issues/1495): Fix false positives for `Rails/TransactionExitStatement` when `break` is used in loop in transactions. ([@koic][])
+* [#1483](https://github.com/rubocop/rubocop-rails/pull/1483): Fix autocorrection error when `Rails/IndexWith` has nested offenses. ([@lovro-bikic][])
+
+### Changes
+
+* [#1500](https://github.com/rubocop/rubocop-rails/pull/1500): Exclude controllers and mailers from `Lint/UselessMethodDefinition`. ([@r7kamura][])
+* [#1474](https://github.com/rubocop/rubocop-rails/issues/1474): Make `Rails/EnumSyntax` include the lib directory by default. ([@koic][])
+* [#1463](https://github.com/rubocop/rubocop-rails/issues/1463): Mark `Rails/IndexWith` as unsafe autocorrect. ([@tejasbubane][])
+
+[@r7kamura]: https://github.com/r7kamura
+[@lovro-bikic]: https://github.com/lovro-bikic
+[@fatkodima]: https://github.com/fatkodima
+[@koic]: https://github.com/koic
+[@tejasbubane]: https://github.com/tejasbubane