Upgrade V8 to 9.0 (#111)

Author: rogchap

.github/workflows/v8build.yml

@@ -7,7 +7,7 @@ jobs:
  name: Build V8 for ${{ matrix.platform }}
  strategy:
  matrix:
- platform: [ubuntu-latest, macos-latest, windows-latest]
+ platform: [ubuntu-18.04, macos-latest, windows-latest]
  runs-on: ${{ matrix.platform }}
  steps:
  - name: Checkout
@@ -19,7 +19,7 @@ jobs:
  run: cd deps/depot_tools && git config --unset-all remote.origin.fetch; git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/*
  shell: bash
  - name: Build V8 linux
- if: matrix.platform == 'ubuntu-latest'
+ if: matrix.platform == 'ubuntu-18.04'
  run: cd deps && ./build.py --no-clang
  - name: Build V8 macOS
  if: matrix.platform == 'macos-latest'

CHANGELOG.md

@@ -8,10 +8,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - Promise resolver and promise result
-- Convert a Value to a Function and invoke it
+- Convert a Value to a Function and invoke it. Thanks to [@robfig](https://github.com/robfig)
+- Windows static binary. Thanks to [@cleiner](https://github.com/cleiner)
+- Setting/unsetting of V8 feature flags
 
 ### Changed
-- Upgrade to V8 8.9.255.20
+- Upgrade to V8 9.0.257.18
 
 ### Fixed
 - Go GC attempting to free C memory (via finalizer) of values after an Isolate is disposed causes a panic

README.md

@@ -133,7 +133,7 @@ V8 requires 64-bit on Windows, therefore it will not work on 32-bit systems.
 
 ## V8 dependency
 
-V8 version: **8.9.255.20** (March 2021)
+V8 version: **9.0.257.18** (April 2021)
 
 In order to make `v8go` usable as a standard Go package, prebuilt static libraries of V8
 are included for Linux, macOS and Windows ie. you *should not* require to build V8 yourself.

deps/build.py

@@ -77,7 +77,6 @@ def apply_mingw_patches():
  v8_build_path = os.path.join(v8_path, "build")
  apply_patch("0000-add-mingw-main-code-changes", v8_path)
  apply_patch("0001-add-mingw-toolchain", v8_build_path)
- apply_patch("0002-fix-mingw-unwind-tables", v8_build_path)
  update_last_change()
  zlib_path = os.path.join(v8_path, "third_party", "zlib")
  zlib_src_gn = os.path.join(deps_path, os_arch(), "zlib.gn")

deps/darwin_x86_64/libv8.a

@@ -4,6 +4,7 @@ include_rules = [
  "+cppgc/common.h",
  # Used by v8-cppgc.h to bridge to cppgc.
  "+cppgc/custom-space.h",
+ "+cppgc/heap-statistics.h",
  "+cppgc/internal/write-barrier.h",
  "+cppgc/visitor.h",
 ]

deps/depot_tools

@@ -16,6 +16,7 @@ per-file v8-inspector-protocol.h=pfeldman@chromium.org
 per-file v8-inspector-protocol.h=kozyatinskiy@chromium.org
 per-file js_protocol.pdl=dgozman@chromium.org
 per-file js_protocol.pdl=pfeldman@chromium.org
+per-file js_protocol.pdl=bmeurer@chromium.org
 
 # For branch updates:
 per-file v8-version.h=file:../INFRA_OWNERS

deps/include/DEPS

@@ -64,6 +64,13 @@ template <typename T>
 class MakeGarbageCollectedTraitBase
  : private internal::MakeGarbageCollectedTraitInternal {
  private:
+ static_assert(internal::IsGarbageCollectedType<T>::value,
+ "T needs to be a garbage collected object");
+ static_assert(!IsGarbageCollectedWithMixinTypeV<T> ||
+ sizeof(T) <=
+ internal::api_constants::kLargeObjectSizeThreshold,
+ "GarbageCollectedMixin may not be a large object");
+
  template <typename U, typename CustomSpace>
  struct SpacePolicy {
  static void* Allocate(AllocationHandle& handle, size_t size) {
@@ -153,12 +160,6 @@ class MakeGarbageCollectedTrait : public MakeGarbageCollectedTraitBase<T> {
  public:
  template <typename... Args>
  static T* Call(AllocationHandle& handle, Args&&... args) {
- static_assert(internal::IsGarbageCollectedType<T>::value,
- "T needs to be a garbage collected object");
- static_assert(
- !internal::IsGarbageCollectedMixinType<T>::value ||
- sizeof(T) <= internal::api_constants::kLargeObjectSizeThreshold,
- "GarbageCollectedMixin may not be a large object");
  void* memory =
  MakeGarbageCollectedTraitBase<T>::Allocate(handle, sizeof(T));
  T* object = ::new (memory) T(std::forward<Args>(args)...);
@@ -169,12 +170,6 @@ class MakeGarbageCollectedTrait : public MakeGarbageCollectedTraitBase<T> {
  template <typename... Args>
  static T* Call(AllocationHandle& handle, AdditionalBytes additional_bytes,
  Args&&... args) {
- static_assert(internal::IsGarbageCollectedType<T>::value,
- "T needs to be a garbage collected object");
- static_assert(
- !internal::IsGarbageCollectedMixinType<T>::value ||
- sizeof(T) <= internal::api_constants::kLargeObjectSizeThreshold,
- "GarbageCollectedMixin may not be a large object");
  void* memory = MakeGarbageCollectedTraitBase<T>::Allocate(
  handle, sizeof(T) + additional_bytes.value);
  T* object = ::new (memory) T(std::forward<Args>(args)...);

deps/include/OWNERS

@@ -10,15 +10,18 @@
 
 namespace cppgc {
 
-// Indicator for the stack state of the embedder.
+/**
+ * Indicator for the stack state of the embedder.
+ */
 enum class EmbedderStackState {
+ /**
+ * Stack may contain interesting heap pointers.
+ */
  kMayContainHeapPointers,
+ /**
+ * Stack does not contain any interesting heap pointers.
+ */
  kNoHeapPointers,
- kUnknown V8_ENUM_DEPRECATED("Use kMayContainHeapPointers") =
- kMayContainHeapPointers,
- kNonEmpty V8_ENUM_DEPRECATED("Use kMayContainHeapPointers") =
- kMayContainHeapPointers,
- kEmpty V8_ENUM_DEPRECATED("Use kNoHeapPointers") = kNoHeapPointers,
 };
 
 } // namespace cppgc