Merge pull request react-grid-layout#1633 from react-grid-layout/chore/deps-lint

Update devDependencies and add PR lint action

Author: STRML

.eslintrc.json

@@ -3,23 +3,36 @@
  "parser": "@babel/eslint-parser",
  "plugins": [
  "react",
- "flowtype"
+ "flowtype",
+ "unicorn"
  ],
  "extends": [
  "eslint:recommended",
  "plugin:react/recommended",
  "plugin:flowtype/recommended"
  ],
  "rules": {
- "no-console": 0,
- "no-use-before-define": [2, "nofunc"],
- "no-unused-vars": [1, {
- "argsIgnorePattern": "^(e|_.*)$",
- "vars": "local",
- "varsIgnorePattern": "(debug|^_)"
- }],
- "prefer-const": 2,
- "react/jsx-boolean-value": [2, "always"]
+ "no-console": "off",
+ "no-use-before-define": [
+ "error",
+ "nofunc"
+ ],
+ "no-unused-vars": [
+ "warn",
+ {
+ "argsIgnorePattern": "^(e|_.*)$",
+ "vars": "local",
+ "varsIgnorePattern": "(debug|^_)"
+ }
+ ],
+ "prefer-const": "error",
+ "react/jsx-boolean-value": [
+ "error",
+ "always"
+ ],
+ "unicorn/better-regex": "warn",
+ "unicorn/expiring-todo-comments": "error",
+ "unicorn/no-abusive-eslint-disable": "error"
  },
  "env": {
  "browser": true,
@@ -31,4 +44,4 @@
  "version": "detect"
  }
  }
-}
+}

.github/workflows/lint.yml

@@ -0,0 +1,37 @@
+name: Lint
+
+on:
+ # Trigger the workflow on push or pull request,
+ # but only for the main branch
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+
+jobs:
+ run-linters:
+ name: Run linters
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Check out Git repository
+ uses: actions/checkout@v2
+
+ - name: Set up Node.js
+ uses: actions/setup-node@v1
+ with:
+ node-version: 14
+
+ - name: Install Node.js dependencies
+ run: yarn
+
+ - name: Run linters
+ uses: wearerequired/lint-action@v1
+ with:
+ eslint: true
+
+ # Flow is not supported by lint-action, so we run it raw
+ - name: Run Flow
+ run: yarn flow

lib/utils.js

@@ -705,7 +705,7 @@ export function synchronizeLayoutWithChildren(
  } else {
  if (!isProduction && child.props._grid) {
  console.warn(
- "`_grid` properties on children have been deprecated as of React 15.2. " + // eslint-disable-line
+ "`_grid` properties on children have been deprecated as of React 15.2. " +
  "Please use `data-grid` or add your properties directly to the `layout`."
  );
  }

package.json

@@ -64,6 +64,7 @@
  "eslint-plugin-flowtype": "^5.9.0",
  "eslint-plugin-mocha": "^9.0.0",
  "eslint-plugin-react": "^7.24.0",
+ "eslint-plugin-unicorn": "^39.0.0",
  "exports-loader": "^3.0.0",
  "flow-bin": "^0.158.0",
  "husky": "^7.0.2",

test/spec/utils-test.js

@@ -80,7 +80,7 @@ describe("validateLayout", () => {
  // $FlowFixMe: dynamic check
  { i: "2", x: 1, y: 2, w: 1 }
  ]);
- }).toThrowError(/layout\[1\]\.h must be a number!/i);
+ }).toThrowError(/layout\[1]\.h must be a number!/i);
  });
 });