Skip to content

Ensure floats are set in high-level setter methods #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ensure floats are set in high-level setter methods #20

wants to merge 1 commit into from

Conversation

auscompgeek
Copy link
Member

Prevents type assertions from failing if an int is passed into CANEncoder.setPosition() or CANPIDController.setIAccum().
virtuald
virtuald reviewed Mar 7, 2019
View reviewed changes
Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Should the autogen insert these automatically?
@auscompgeek
Copy link
Member Author

That'd probably be a good idea actually… that'll happen in pybind11, so why not do it in simulation too?
@auscompgeek auscompgeek mentioned this pull request Apr 16, 2019
Merged
@virtuald virtuald closed this in #21 May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@auscompgeek @virtuald