Fixes Material-UI inline checkboxes #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adam-beck commented Sep 8, 2020
| onFocus={_onFocus} | ||
| /> | ||
| ); | ||
| return inline ? ( |
There was a problem hiding this comment.
I try not to refactor within unrelated commits but this seemed relevant since the code block removed used the inline property. I'm not sure why this was done but this is redundant regardless because both sides of the ternary return the same thing.
| Ran into this issue earlier today. Glad there's a fix for it @agustin107 @epicfaace Any ideas when can this be merged? |
epicfaace approved these changes Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes an issue when setting the UI to display checkboxes inline does not honor the configuration. This fix only applies to the material-ui package.
Fixes #2021
Checklist