fix(Select): fix custom colors #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tjbo commented Oct 2, 2021
| if you use But if you want to contribute changes for use |
github-actions bot pushed a commit that referenced this pull request Oct 3, 2021
# [1.2.0-next.8](v1.2.0-next.7...v1.2.0-next.8) (2021-10-03) ### Bug Fixes * **Select:** fix custom colors ([#22](#22)) ([8d9182e](8d9182e)) ### Chores * fix lint-staged for res or resi ([#20](#20)) ([6054fc9](6054fc9)) * **deps, lint:** add lint with husky and lint-staged ([#18](#18)) ([987d76a](987d76a)) ### Documentation * **Website:** add docs website ([#19](#19)) ([1e27b6b](1e27b6b))
| 🎉 This PR is included in version 1.2.0-next.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-09-04) ### Bug Fixes * **Components:** wrong type definition for ReactEvent.* ([87cc911](87cc911)) * **Input:** add value for Input ([#26](#26)) ([5cb98fc](5cb98fc)) * **Link:** missing anchor HTML element attributes ([3b4477d](3b4477d)) * **props:** fix invalid props for all Components ([1703258](1703258)) * **Select:** fix custom colors ([#22](#22)) ([8d9182e](8d9182e)) ### Features * **Fade, ScaleFade, Slide:** add component binding for Fade, ScaleFade, & Slide ([7b30d49](7b30d49)) * **Feedback:** add component binding for feedback ([#16](#16)) ([e68c2cb](e68c2cb)) * **Input:** add binding for Input ([#23](#23)) ([7cdf3f9](7cdf3f9)) * **Input:** add binding for Input extra ([#24](#24)) ([4a6e846](4a6e846)) * **Interfaces:** add binding for some HTML specification ([0b1040e](0b1040e)) * **MakeProps:** add sub-modules in MakeProps for handle object-fit, noOfLines, viewBox, and multi-type(string-or-number). ([51a1924](51a1924)) * **Media:** add bindin for Icon and Image Component ([762108e](762108e)) * **Media:** add binding component Avatar & AvatarGroup. ([a96e39e](a96e39e)) * **Navigation:** add binding for component navigation ([4428ec8](4428ec8)) * **Others:** add binding for Portal Component ([68e9679](68e9679)) * **Select:** add bindings for select ([#17](#17)) ([26e9b43](26e9b43)) * **Select:** fix syntax ([ba061dd](ba061dd)) * **Spacer:** add binding for Spacer component ([#25](#25)) ([e3ce148](e3ce148)) * support for rescript v11 ([#29](#29)) ([b87ffe5](b87ffe5)) * **Typography:** add binding for Heading and Text ([9f707a2](9f707a2))
| 🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes the custom colors which weren't being passed in properly for the recent Select Menu I added.
Just one thought on this; would be great to be able to be able to QA stuff (especially for me who is a bit of a noob at the RS thing).
I messed around a bit with BS-CONFIG, and a basic HTTP-SERVER, but thought I'd bring it up with you; to see what your thoughts are.
If you don't have time, I could implement something; let me know.
I found that RS build system to be a bit lacking; in terms of getting a fully functioning mounted package.
If it's build as a
commonjsmodule, the require function is not included, and if it's build ases6we'd need to use something like an import map, which is probably not ideal:Or I guess there are other more industrial options like webpack.
Any thoughts?
It would allow myself and others to move a bit faster and steadier with QAing our code before opening a commit.
Instead of QAing after a release and having to make a commit like this.
;)