Remove unused non-bs code #6942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DZakh commented Aug 7, 2024
| (* fast path, and keep track of simple bindings to unboxable numbers *) | ||
| Llet(Strict, Pgenval, id, param, body) | ||
| | _ -> | ||
| (* Turn off such optimization to reduce diff in the beginning - FIXME*) |
Member Author
There was a problem hiding this comment.
An interesting optimisation, which might be worth resurrecting in the future
DZakh commented Aug 7, 2024
jscomp/ml/matching.ml Outdated
Comment on lines 2312 to 2316
| let tag = Ident.create "tag" in | ||
| let tests = | ||
| List.fold_right | ||
| (fun (path, act) rem -> | ||
| let ext = transl_extension_path ex_pat.pat_env path in | ||
| Lifthenelse(Lprim(extension_slot_eq , [Lvar tag; ext], loc), | ||
| act, rem)) | ||
| nonconsts | ||
| default | ||
| in | ||
| Llet(Alias, Pgenval,tag, arg, tests) | ||
| List.fold_right | ||
| (fun (path, act) rem -> | ||
| let ext = transl_extension_path ex_pat.pat_env path in | ||
| Lifthenelse(Lprim(extension_slot_eq , [arg; ext], loc), | ||
| act, rem)) | ||
| nonconsts | ||
| default |
Member Author
There was a problem hiding this comment.
@cristianoc this code is commited by mistake from my investigation on how the try/catch compilation works.
I couldn't figure where the tag Llet is used, so I removed it. Could you correct me If I'm wrong.
cristianoc approved these changes Aug 8, 2024
Collaborator
cristianoc left a comment
cristianoc left a comment There was a problem hiding this comment.
Would you undo changes not related to the flag and put them in a separate PR?
Member Author
| @cristianoc Done |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.