Skip to content

Commit 44e0553

Browse files
committed
Flow: Print tvar ids in comments.
1 parent 85f4cd1 commit 44e0553

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

jscomp/flow.ml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,7 @@ and p_type_decl s type_decl =
4747
and p_type_expr s type_expr =
4848
match type_expr.desc with
4949
| Tvar str ->
50-
let str = match str with
51-
| Some x -> x
52-
| None -> "-" in
53-
p_any ("Tvar " ^ str)
50+
p_any ("Tvar " ^ (string_of_int type_expr.id))
5451
| Tarrow (label, left, right, c) -> p_arrow s (label, left, right, c)
5552
| Ttuple tl -> T_tuple (List.map (p_type_expr s) tl)
5653
| Tconstr (path, tl, _) ->
@@ -71,7 +68,7 @@ and p_type_expr s type_expr =
7168
let decl = {decl_name; decl_type} in
7269
s.types <- decl :: s.types
7370
end;
74-
p_named decl_name
71+
p_named ~tl:(List.map (p_type_expr s) tl) decl_name
7572
end
7673
| Tobject _ -> p_any "Tobject"
7774
| Tfield _ -> p_any "Tfield" (* Shouldn't ever happen? *)

jscomp/test_flow/main.js

Lines changed: 8 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jscomp/test_flow/main.js.flow

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ declare export var mk_tuple: (p0: M__t, p1: number, p2: void) => [number, number
1818

1919
declare export var mk_rec: (p0: obj_t) => rec_t;
2020

21-
declare export var mk_obj: (p0: /* Tvar - */any) => {id: number, name: string};
21+
declare export var mk_obj: (p0: /* Tvar 1912 */any) => {id: number, name: string};
2222

2323
declare export var mk_arr: (p0: void) => Array<number>;
2424

@@ -27,3 +27,5 @@ declare export var from_util: (p0: Util__t) => void;
2727
declare export var float_: number;
2828

2929
declare export var tt: tt$0;
30+
31+
declare export var iter: (p0: Array</* Tvar 2242 */any>, p1: Array</* Tvar 2255 */any>, p2: (p0: /* Tvar 2242 */any) => void, p3: (p0: /* Tvar 2255 */any) => void) => void;

jscomp/test_flow/main.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ let float_ = 1.0
3232

3333
type tt = int
3434
let tt: tt = 0
35+
36+
let iter items1 items2 fn1 fn2 = Array.iter fn1 items1; Array.iter fn2 items2

0 commit comments

Comments
 (0)