Skip to content

Commit 6830800

Browse files
committed
Switch to http-conduit from http-enumerator.
1 parent 3d1c84c commit 6830800

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

Github/Data/Definitions.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ module Github.Data.Definitions where
44

55
import Data.Time
66
import Data.Data
7-
import Network.HTTP.Enumerator (HttpException(..))
7+
import Network.HTTP.Conduit (HttpException(..))
88
import qualified Control.Exception as E
99

10-
deriving instance Eq Network.HTTP.Enumerator.HttpException
10+
deriving instance Eq Network.HTTP.Conduit.HttpException
1111

1212
-- | Errors have been tagged according to their source, so you can more easily
1313
-- dispatch and handle them.

Github/Private.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import Data.List
99
import qualified Data.ByteString.Char8 as BS
1010
import qualified Data.ByteString.Lazy.Char8 as LBS
1111
import qualified Network.HTTP.Types as Types
12-
import Network.HTTP.Enumerator
12+
import Network.HTTP.Conduit
1313
import Text.URI
1414
import Control.Failure hiding (Error(..))
1515
import qualified Control.Exception as E
@@ -38,12 +38,12 @@ githubAPI method url body = do
3838
result
3939
where encodedBody = RequestBodyLBS $ encode $ toJSON body
4040

41-
doHttps :: BS.ByteString -> String -> Maybe (RequestBody IO) -> IO (Either E.IOException Response)
41+
doHttps :: BS.ByteString -> String -> Maybe (RequestBody IO) -> IO (Either E.IOException (Response LBS.ByteString))
4242
doHttps method url body = do
4343
let (Just uri) = parseURI url
4444
(Just host) = uriRegName uri
4545
requestBody = fromMaybe (RequestBodyBS $ BS.pack "") body
46-
queryString = Types.parseQuery $ BS.pack $ fromMaybe "" $ uriQuery uri
46+
queryString = BS.pack $ fromMaybe "" $ uriQuery uri
4747
request = def { method = method
4848
, secure = True
4949
, host = BS.pack host

Github/Repos/Collaborators.hs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ import Github.Data
1010
import Github.Private
1111

1212
import Data.ByteString.Char8 (pack)
13-
import Network.HTTP.Enumerator (statusCode)
13+
import qualified Network.HTTP.Conduit as C (statusCode)
14+
import qualified Network.HTTP.Types as T (statusCode)
1415

1516
-- | All the users who have collaborated on a repo.
1617
--
@@ -30,5 +31,5 @@ isCollaboratorOn userName repoOwnerName repoName = do
3031
(buildUrl ["repos", repoOwnerName, repoName, "collaborators", userName])
3132
Nothing
3233
return $ either (Left . HTTPConnectionError)
33-
(Right . (204 ==) . statusCode)
34+
(Right . (204 ==) . T.statusCode . C.statusCode)
3435
result

github.cabal

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ Library
152152
old-locale,
153153
HTTP,
154154
network,
155-
http-enumerator == 0.7.2.1,
155+
http-conduit == 1.1.0.1,
156156
uri,
157157
failure,
158158
http-types,

0 commit comments

Comments
 (0)