Avoid mutating a global retry_on_error list

Author: elemoine

redis/client.py

@@ -914,7 +914,7 @@ def __init__(
  errors=None,
  decode_responses=False,
  retry_on_timeout=False,
- retry_on_error=[],
+ retry_on_error=None,
  ssl=False,
  ssl_keyfile=None,
  ssl_certfile=None,
@@ -958,6 +958,8 @@ def __init__(
  )
  )
  encoding_errors = errors
+ if not retry_on_error:
+ retry_on_error = []
  if retry_on_timeout is True:
  retry_on_error.append(TimeoutError)
  kwargs = {

redis/connection.py

@@ -520,7 +520,7 @@ def __init__(
  socket_keepalive_options=None,
  socket_type=0,
  retry_on_timeout=False,
- retry_on_error=[],
+ retry_on_error=SENTINEL,
  encoding="utf-8",
  encoding_errors="strict",
  decode_responses=False,
@@ -552,6 +552,8 @@ def __init__(
  self.socket_keepalive_options = socket_keepalive_options or {}
  self.socket_type = socket_type
  self.retry_on_timeout = retry_on_timeout
+ if retry_on_error is SENTINEL:
+ retry_on_error = []
  if retry_on_timeout:
  # Add TimeoutError to the errors list to retry on
  retry_on_error.append(TimeoutError)
@@ -1071,7 +1073,7 @@ def __init__(
  encoding_errors="strict",
  decode_responses=False,
  retry_on_timeout=False,
- retry_on_error=[],
+ retry_on_error=SENTINEL,
  parser_class=DefaultParser,
  socket_read_size=65536,
  health_check_interval=0,
@@ -1094,6 +1096,8 @@ def __init__(
  self.password = password
  self.socket_timeout = socket_timeout
  self.retry_on_timeout = retry_on_timeout
+ if retry_on_error is SENTINEL:
+ retry_on_error = []
  if retry_on_timeout:
  # Add TimeoutError to the errors list to retry on
  retry_on_error.append(TimeoutError)