Skip to content

fix(aggregate, search): ft.aggregate bugfixes #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 7, 2025
Merged

fix(aggregate, search): ft.aggregate bugfixes #3263

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
28e79aa
fix: rearange args for ft.aggregate
ndyakov Feb 6, 2025
064c83f
improve test
ndyakov Feb 6, 2025
25ae60d
wip: add scorer and addscores
ndyakov Feb 6, 2025
3bb8051
enable all tests
ndyakov Feb 6, 2025
3bc9a57
fix ftsearch with count test
ndyakov Feb 6, 2025
35101a5
make linter happy
ndyakov Feb 6, 2025
46f97c7
Addscores is available in later redisearch releases.
ndyakov Feb 6, 2025
f4e7c76
load an apply seem to break scorer and addscores
ndyakov Feb 6, 2025
cf190be
Merge branch 'master' into ndyakov/ft-aggregate-bugfixes
ndyakov Feb 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make linter happy
  • Loading branch information
@ndyakov
ndyakov committed Feb 6, 2025
commit 35101a5da08a2ea0f5adb3e077c3064993a36b51
5 changes: 2 additions & 3 deletions search_commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ func FTAggregateQuery(query string, options *FTAggregateOptions) AggregateQuery
queryArgs = append(queryArgs, "SCORER", options.Scorer)
}

if options.AddScores == true {
if options.AddScores {
queryArgs = append(queryArgs, "ADDSCORES")
}

Expand Down Expand Up @@ -727,7 +727,7 @@ func (c cmdable) FTAggregateWithArgs(ctx context.Context, index string, query st
if options.Scorer != "" {
args = append(args, "SCORER", options.Scorer)
}
if options.AddScores == true {
if options.AddScores {
args = append(args, "ADDSCORES")
}
if options.GroupBy != nil {
Expand Down Expand Up @@ -803,7 +803,6 @@ func (c cmdable) FTAggregateWithArgs(ctx context.Context, index string, query st
}

cmd := NewAggregateCmd(ctx, args...)
cmd.err = cmd.err
_ = c(ctx, cmd)
return cmd
}
Expand Down
Loading