Skip to content

Commit 8e8ed1d

Browse files
committed
[C++]: changed code-generation test schema to use a different string for Booster to catch issues like aeron-io#435. Fixed includes and declarations use correct name.
1 parent 323ece0 commit 8e8ed1d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public List<String> generateTypeStubs() throws IOException
8787
break;
8888
}
8989

90-
typesToInclude.add(tokens.get(0).name());
90+
typesToInclude.add(tokens.get(0).contextualTypeName());
9191
}
9292

9393
return typesToInclude;
@@ -104,7 +104,7 @@ public List<String> generateTypesToIncludes(final List<Token> tokens)
104104
case BEGIN_ENUM:
105105
case BEGIN_SET:
106106
case BEGIN_COMPOSITE:
107-
typesToInclude.add(token.name());
107+
typesToInclude.add(token.contextualTypeName());
108108
break;
109109
}
110110
}
@@ -1520,7 +1520,7 @@ private CharSequence generateEnumProperty(
15201520
final Token token,
15211521
final String indent)
15221522
{
1523-
final String enumName = formatClassName(token.name());
1523+
final String enumName = formatClassName(token.contextualTypeName());
15241524
final String typeName = cppTypeName(token.encoding().primitiveType());
15251525
final int offset = token.offset();
15261526

@@ -1587,7 +1587,7 @@ private static Object generateBitsetProperty(final String propertyName, final To
15871587
{
15881588
final StringBuilder sb = new StringBuilder();
15891589

1590-
final String bitsetName = formatClassName(token.name());
1590+
final String bitsetName = formatClassName(token.contextualTypeName());
15911591
final int offset = token.offset();
15921592

15931593
sb.append(String.format(
@@ -1623,7 +1623,7 @@ private static Object generateBitsetProperty(final String propertyName, final To
16231623

16241624
private static Object generateCompositeProperty(final String propertyName, final Token token, final String indent)
16251625
{
1626-
final String compositeName = formatClassName(token.name());
1626+
final String compositeName = formatClassName(token.contextualTypeName());
16271627
final int offset = token.offset();
16281628

16291629
final StringBuilder sb = new StringBuilder();

sbe-tool/src/test/resources/code-generation-schema.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<type name="VehicleCode" primitiveType="char" length="6" characterEncoding="ASCII"/>
2828
<type name="someNumbers" primitiveType="int32" length="5"/>
2929
<type name="Ron" primitiveType="uint8" minValue="90" maxValue="110"/>
30-
<composite name="Booster">
30+
<composite name="BoosterT">
3131
<enum name="BoostType" encodingType="char">
3232
<validValue name="TURBO">T</validValue>
3333
<validValue name="SUPERCHARGER">S</validValue>
@@ -42,7 +42,7 @@
4242
<type name="maxRpm" primitiveType="uint16" presence="constant">9000</type>
4343
<type name="manufacturerCode" primitiveType="char" length="3"/>
4444
<type name="fuel" primitiveType="char" presence="constant">Petrol</type>
45-
<ref name="booster" type="Booster"/>
45+
<ref name="booster" type="BoosterT"/>
4646
</composite>
4747
<enum name="BooleanType" encodingType="uint8">
4848
<validValue name="F">0</validValue>

0 commit comments

Comments
 (0)