fix: onClose only trigger when open (#371)

Author: zombieJ

src/DrawerPopup.tsx

@@ -210,7 +210,7 @@ export default function DrawerPopup(props: DrawerPopupProps) {
  ...motionMaskStyle,
  ...maskStyle,
  }}
- onClick={maskClosable ? onClose : undefined}
+ onClick={maskClosable && open ? onClose : undefined}
  ref={maskRef}
  />
  );

tests/motion.spec.tsx

@@ -1,4 +1,4 @@
-import { render } from '@testing-library/react';
+import { render, fireEvent } from '@testing-library/react';
 import React from 'react';
 import Drawer from '../src';
 
@@ -36,4 +36,41 @@ describe('motion', () => {
  background: 'red',
  });
  });
+
+ it('mask close should only trigger once', () => {
+ let closeCount = 0;
+
+ const Demo = () => {
+ const [open, setOpen] = React.useState(true);
+ const onClose = () => {
+ closeCount += 1;
+ setOpen(false);
+ };
+
+ const sharedMotion = {
+ motionName: 'bamboo',
+ motionAppear: false,
+ motionEnter: false,
+ motionLeave: true,
+ };
+
+ return (
+ <Drawer
+ motion={sharedMotion}
+ maskMotion={sharedMotion}
+ open={open}
+ onClose={onClose}
+ getContainer={false}
+ />
+ );
+ };
+
+ const { container } = render(<Demo />);
+
+ for (let i = 0; i < 10; i += 1) {
+ fireEvent.click(container.querySelector('.rc-drawer-mask'));
+ }
+
+ expect(closeCount).toBe(1);
+ });
 });