Fix for drive letters #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`Pathname#relative_path_from` raises an `ArgumentError` when the self path and the base directory have different prefixes, on Windows and DOSish systems which have drive letters (or UNC). The absolute path just works fine in that case.
hsbt added a commit to ruby/ruby that referenced this pull request Aug 28, 2015
ruby/rdoc#337 ruby/rdoc#367 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nurse pushed a commit to nurse/ruby that referenced this pull request Sep 18, 2015
ruby/rdoc#337 ruby/rdoc#367 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51715 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt added a commit to ruby/ruby that referenced this pull request Dec 22, 2015
ruby/rdoc#340 ruby/rdoc#341 ruby/rdoc#367 ruby/rdoc#368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mrkn pushed a commit to mrkn/ruby that referenced this pull request Apr 17, 2016
ruby/rdoc#340 ruby/rdoc#341 ruby/rdoc#367 ruby/rdoc#368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This was referenced Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pathname#relative_path_fromraises anArgumentErrorwhen theself path and the base directory have different prefixes, on
Windows and DOSish systems which have drive letters (or UNC).
The absolute path just works fine in that case.