Support resetting Picoprobe board using USB RESET interface (RP2040) #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… USB_RESET interface
P33M requested changes Nov 20, 2023
Contributor
P33M left a comment
P33M left a comment There was a problem hiding this comment.
Thanks for the PR - I have left review comments below.
| #define PROBE_PRODUCT_STRING "Picoprobe (CMSIS-DAP)" | ||
| | ||
| // Host Reset Config | ||
| #define PICOPROBE_RESET_CAPABLE 1 |
Contributor
There was a problem hiding this comment.
I would prefer disabled by default. I would guess that for other users the feature would aid remote development of the probe firmware itself, but the vast majority will be doing uf2 drag-and-drop with a Pico or a Debug Probe and a standard release.
So, please move this definition to include/board_example_config.h with a suitable description.
| #if PICOPROBE_RESET_CAPABLE | ||
| if (request->wIndex == 3) { | ||
| if (request->bRequest == RESET_REQUEST_BOOTSEL) { | ||
| reset_usb_boot(0, (request->wValue & 0x7f) | 0); |
Contributor
There was a problem hiding this comment.
Superfluous bitwise OR with zero
| @@ -0,0 +1,28 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
Can the reset interface definitions be included with a Cmake library linkage instead of a repeat inclusion of the sdk header?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have a use-case involving reusing RP2040 supervisor as an SWD debug interface during initial testing. This implements standard Pico SDK C++ usb reset endpoints to interoperate with appropriately patched picotool. The patch enables this functionality by default, but it can be disabled with a config switch to avoid accidentally rebooting the incorrect RP2040 device.
raspberrypi/picotool@master...FarProbe:picotool:master