Add picoprobe-only EXTRA_UART cmake option #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… over USB-CDC as tty1 New CDC_UARTS count placed in CMakeLists.txt to ensure tusb_config.h and cdc_uart.c can see it. CMakeLists.txt, picoprobe_config.h, board_pico_config.h, tusb_config.h, main.c, cdc_uart.h, cdc_uart.c, usb_descriptors.c Extra usb descriptor, interfaces and endpoints when needed. desc_ms_os_20 NOT updated. cdc_task() gets new tty index param (extant UART always tty0). was_connected and usb rx/tx buffers now module-static arrays with tty index. All tud_cdc_* calls changed to tud_cdc_n_* variants, PICOPROBE_UART_RX/TX_LED remain tty0-only. Basic testing: Pi4B host, THREADED 1, DAP_V2: minicom receives uart output(s), openocd 'program xxx.elf verify reset exit' works.
| Thanks, this is very useful |
| Any chance that this PR will be merged any time soon? |
Contributor
| Please retest this on top of latest master - there have been changes which will impact this PR. |
Contributor
| There's a blocker to merging this - if I have one UART with a high baudrate, then set the other UART to a low baudrate, the cdc thread gets a slow polling interval. This will drop characters. This needs reworking to spawn another RTOS thread for the second CDC interface. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
bridges 2nd hardware UART over USB-CDC as tty1
New CDC_UARTS count placed in CMakeLists.txt to ensure tusb_config.h and cdc_uart.c can see it.
CMakeLists.txt, picoprobe_config.h, board_pico_config.h, tusb_config.h, main.c, cdc_uart.h, cdc_uart.c, usb_descriptors.c
Extra usb descriptor, interfaces and endpoints when needed. desc_ms_os_20 NOT updated.
cdc_task() gets new tty index param (extant UART always tty0). was_connected and usb rx/tx buffers now module-static arrays with tty index. All tud_cdc_* calls changed to tud_cdc_n_* variants, PICOPROBE_UART_RX/TX_LED remain tty0-only. Basic testing: Pi4B host, THREADED 1, DAP_V2: minicom receives uart output(s), openocd 'program xxx.elf verify reset exit' works.