[Java] Warnings tidy up.

Author: mjpt777

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStub.java

@@ -208,7 +208,7 @@ public static void decode(
  sb.append("\ncar.engine.booster.horsePower=").append(engine.booster().horsePower());
 
  sb.append("\ncar.engine.fuel=").append(
- new String(buffer, 0, engine.getFuel(buffer, 0, buffer.length), "ASCII"));
+ new String(buffer, 0, engine.getFuel(buffer, 0, buffer.length), StandardCharsets.US_ASCII));
 
  for (final CarDecoder.FuelFiguresDecoder fuelFigures : car.fuelFigures())
  {

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStubExtension.java

@@ -24,6 +24,7 @@
 import java.io.UnsupportedEncodingException;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Paths;
 
 import static extension.CarEncoder.cupHolderCountNullValue;
@@ -211,7 +212,7 @@ public static void decode(
  sb.append("\ncar.engine.booster.horsePower=").append(engine.booster().horsePower());
 
  sb.append("\ncar.engine.fuel=").append(
- new String(buffer, 0, engine.getFuel(buffer, 0, buffer.length), "ASCII"));
+ new String(buffer, 0, engine.getFuel(buffer, 0, buffer.length), StandardCharsets.US_ASCII));
 
  final String cupHolderCount =
  car.cupHolderCount() == cupHolderCountNullValue() ? "null" : car.cupHolderCount() + "";

sbe-tool/src/main/java/uk/co/real_logic/sbe/PrimitiveValue.java

@@ -417,7 +417,7 @@ public String toString()
  */
  public boolean equals(final Object value)
  {
- if (null != value && value instanceof PrimitiveValue)
+ if (value instanceof PrimitiveValue)
  {
  final PrimitiveValue rhs = (PrimitiveValue)value;
 

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/csharp/CSharpGenerator.java

@@ -1254,14 +1254,12 @@ private String generateByteOrder(final ByteOrder byteOrder, final int primitiveT
  return "";
  }
 
- switch (byteOrder.toString())
+ if ("BIG_ENDIAN".equals(byteOrder.toString()))
  {
- case "BIG_ENDIAN":
- return "BigEndian";
-
- default:
- return "LittleEndian";
+ return "BigEndian";
  }
+
+ return "LittleEndian";
  }
 
  private String generateLiteral(final PrimitiveType type, final String value)

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/golang/GolangGenerator.java

@@ -686,7 +686,7 @@ private int generateEncodeDecode(
  encode.append(generateEncodeOffset(gap, ""));
  decode.append(generateDecodeOffset(gap, ""));
  currentOffset += signalToken.encodedLength() + gap;
- final String primitive = Character.toString(varName) + "." + propertyName;
+ final String primitive = varName + "." + propertyName;
 
  // Encode of a constant is a nullop and we want to
  // initialize constant values.
@@ -1044,7 +1044,7 @@ private int generateFieldEncodeDecode(
  gap = encodingToken.offset() - currentOffset;
  encode.append(generateEncodeOffset(gap, ""));
  decode.append(generateDecodeOffset(gap, ""));
- final String primitive = Character.toString(varName) + "." + propertyName;
+ final String primitive = varName + "." + propertyName;
 
  // Encode of a constant is a nullop and we want to
  // initialize constant values.

sbe-tool/src/main/java/uk/co/real_logic/sbe/json/JsonTokenListener.java

@@ -120,7 +120,7 @@ public void onBitSet(
  final long bitPosition = tokens.get(i).encoding().constValue().longValue();
  final boolean flag = (encodedValue & (1L << bitPosition)) != 0;
 
- output.append(Boolean.toString(flag));
+ output.append(flag);
 
  if (i < (toIndex - 1))
  {

sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/IrGenerator.java

@@ -21,7 +21,7 @@
 import uk.co.real_logic.sbe.ir.Signal;
 import uk.co.real_logic.sbe.ir.Token;
 
-import java.io.UnsupportedEncodingException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -128,14 +128,7 @@ private void addFieldSignal(final Field field, final Signal signal)
  {
  final String valueRef = field.valueRef();
  final byte[] bytes;
- try
- {
- bytes = valueRef.getBytes("UTF-8");
- }
- catch (final UnsupportedEncodingException ex)
- {
- throw new RuntimeException(ex);
- }
+ bytes = valueRef.getBytes(StandardCharsets.UTF_8);
 
  encodingBuilder.constValue(new PrimitiveValue(bytes, "UTF-8", valueRef.length()));
  encodingBuilder.primitiveType(PrimitiveType.CHAR);