Skip to content

Commit ec87076

Browse files
michaelklishinmergify[bot]
authored andcommitted
Revert "HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call"
This reverts commit 78f901a. (cherry picked from commit 7ebaae7) # Conflicts: # deps/rabbitmq_management/src/rabbit_mgmt_wm_queue.erl (cherry picked from commit 7042bc4) # Conflicts: # deps/rabbitmq_management/src/rabbit_mgmt_wm_queue.erl
1 parent 39424d5 commit ec87076

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

deps/rabbitmq_management/src/rabbit_mgmt_wm_queue.erl

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,17 @@ accept_content(ReqData, Context) ->
7171
rabbit_mgmt_util:bad_request(iolist_to_binary(io_lib:format(F ++ "~n", A)), ReqData, Context)
7272
end.
7373

74-
delete_resource(ReqData, Context = #context{user = #user{username = ActingUser}}) ->
74+
delete_resource(ReqData, Context) ->
7575
%% We need to retrieve manually if-unused and if-empty, as the HTTP API uses '-'
7676
%% while the record uses '_'
7777
IfUnused = <<"true">> =:= rabbit_mgmt_util:qs_val(<<"if-unused">>, ReqData),
7878
IfEmpty = <<"true">> =:= rabbit_mgmt_util:qs_val(<<"if-empty">>, ReqData),
79+
<<<<<<< HEAD
7980
VHost = rabbit_mgmt_util:id(vhost, ReqData),
81+
=======
82+
<<<<<<< HEAD
83+
VHost = rabbit_mgmt_util:id(vhost, ReqData),
84+
>>>>>>> 7042bc4864 (Revert "HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call")
8085
QName = rabbit_mgmt_util:id(queue, ReqData),
8186
Name = rabbit_misc:r(VHost, queue, QName),
8287
case rabbit_amqqueue:lookup(Name) of
@@ -96,6 +101,15 @@ delete_resource(ReqData, Context = #context{user = #user{username = ActingUser}}
96101
{error, not_found} ->
97102
{true, ReqData, Context}
98103
end.
104+
=======
105+
Name = rabbit_mgmt_util:id(queue, ReqData),
106+
rabbit_mgmt_util:direct_request(
107+
'queue.delete',
108+
fun rabbit_mgmt_format:format_accept_content/1,
109+
[{queue, Name},
110+
{if_unused, IfUnused},
111+
{if_empty, IfEmpty}], "Delete queue error: ~ts", ReqData, Context).
112+
>>>>>>> 7ebaae7ef0 (Revert "HTTP API: DELETE /api/queues/{vhost}/{name} use internal API call")
99113

100114
is_authorized(ReqData, Context) ->
101115
rabbit_mgmt_util:is_authorized_vhost(ReqData, Context).

deps/rabbitmq_management/test/rabbit_mgmt_http_SUITE.erl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1994,7 +1994,9 @@ queue_purge_test(Config) ->
19941994
http_delete(Config, "/queues/%2F/myqueue/contents", {group, '2xx'}),
19951995
http_delete(Config, "/queues/%2F/badqueue/contents", ?NOT_FOUND),
19961996
http_delete(Config, "/queues/%2F/exclusive/contents", ?BAD_REQUEST),
1997-
http_delete(Config, "/queues/%2F/exclusive", {group, '2xx'}),
1997+
http_delete(Config, "/queues/%2F/exclusive", ?BAD_REQUEST),
1998+
#'basic.get_empty'{} =
1999+
amqp_channel:call(Ch, #'basic.get'{queue = <<"myqueue">>}),
19982000
close_channel(Ch),
19992001
close_connection(Conn),
20002002
http_delete(Config, "/queues/%2F/myqueue", {group, '2xx'}),

0 commit comments

Comments
 (0)