feat: dbQuoteLiteral() correctly quotes 64-bit integers from the bit64 package (of class "integer64") #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
krlmlr changed the title dbQuoteLiteral() correctly quotes 64-bit integers from the bit64 package (of class "integer64") 
| Thanks! I wonder why not use |
| Sorry, for some reason I thought RPostgres didn't have a direct dependency on bit64, but I see that it actually does. I can update if you want. |
| Thanks, there's no need -- it's easily done when we touch the code the next time. |
krlmlr added a commit that referenced this pull request Mar 31, 2024
RPostgres 1.4.6 - Breaking change: `dbListObjects()` only allows `Id()` objects as `prefix` argument (@dpprdan, #390). - Use `NULL` in favor of `NULL::text` when quoting strings and literals, to support JSON and other text-ish types. Fixes a regression introduced in #370 (#393, #425). - `dbQuoteLiteral()` correctly quotes 64-bit integers from the bit64 package (of class `"integer64"`) (@karawoo, #435, #436). - Breaking change: `dbListObjects()` only allows `Id()` objects as `prefix` argument (@dpprdan, #390). - Windows: update to libpq-15.3 (#442). - Upgrade boost to 1.81.0-1 to fix sprintf warnings (#417). - Suppress warning in gcc-12 (#443). - Tweak driver docs (@dpprdan, #433). - Relicense as MIT. - Close result set. - Replace Rcpp by cpp11 (@Antonov548, #419).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #435 by adding a branch of logic to
dbQuoteLiteral_PqConnectionthat checks if the value is integer64, and if so appending::int8.