fix: pagination #499
Merged
fix: pagination #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gioboa approved these changes Nov 12, 2023
Contributor
gioboa left a comment
gioboa left a comment There was a problem hiding this comment.
That's an amazing work @fabiobiondi
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What is it?
Description
I have fixed how items are generated the pagination item.
The new algorithm does not support
boundaryCountanymore but it should mimic the melt-ui pagination component.A preview:
2023-11-11_05-31-23.mp4
DOCUMENTATION
I have added styles to the documentation.
This doc is still not completed but it should be more consistent and prettier than previous version
FIXED
I have fixed some behaviors: