Added type check to keyboard navigation #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
christianfuttrup requested review from Mathys-Gasnier, psychlone77 and saminjay as code owners This reverts commit 2d59cca.
psychlone77 approved these changes Jan 5, 2025
Collaborator
psychlone77 left a comment
psychlone77 left a comment There was a problem hiding this comment.
Looks good 👍. Thank you for your contribution.
Mathys-Gasnier approved these changes Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to ensure that the
switchcases don't accept a random string from theKeyboardEventbut rather only the ones that we expect. Furthermore, eachcasein theswitchstatement doesn't handlepreventDefaultanymore; it has been moved to all cases that meet thekeyswe expect.Type of Change
Checklist
Related Issues
#140 (same context)