Skip to content

Commit f7da611

Browse files
committed
Supply port id via constructor
1 parent 22eb446 commit f7da611

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

qtoggleserver/cmdline/peripheral.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ async def make_port_args(self) -> List[Dict[str, Any]]:
155155

156156
return [{
157157
'driver': CommandLinePort,
158-
'port_id': p['id'],
159-
'port_type': p['type'],
158+
'id': p['id'],
159+
'type': p['type'],
160160
'writable': self._write_command is not None
161161
} for p in self._port_details]

qtoggleserver/cmdline/ports.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,21 @@
88

99

1010
class CommandLinePort(polled.PolledPort):
11-
def __init__(self, *, port_id: str, port_type: str, writable: bool, **kwargs) -> None:
12-
self._port_id: str = port_id
13-
self._type: str = port_type
11+
def __init__(self, *, id: str, type: str, writable: bool, **kwargs) -> None:
12+
self._type = type
1413
self._writable = writable
1514

16-
super().__init__(**kwargs)
15+
super().__init__(id=id, **kwargs)
1716

1817
def get_peripheral(self) -> CommandLine:
1918
return cast(CommandLine, super().get_peripheral())
2019

21-
def make_id(self) -> str:
22-
return self._port_id
23-
2420
async def write_value(self, value: PortValue) -> None:
2521
peripheral = self.get_peripheral()
26-
peripheral.update_value(self._port_id, value)
22+
peripheral.update_value(self.get_initial_id(), value)
2723

2824
await peripheral.write_values()
2925

3026
async def read_value(self) -> NullablePortValue:
31-
value = self.get_peripheral().get_value(self._port_id)
27+
value = self.get_peripheral().get_value(self.get_initial_id())
3228
return await self.adapt_value_type(value)

0 commit comments

Comments
 (0)