Skip to content

Commit f033292

Browse files
committed
tst_QTextEdit: port away from QPair
Pick-to: 6.10 6.8 6.5 Task-number: QTBUG-115841 Change-Id: I3a749cab756f77641d698e5413561a63e5a425c9 Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
1 parent 4346e55 commit f033292

File tree

1 file changed

+39
-31
lines changed

1 file changed

+39
-31
lines changed

tests/auto/widgets/widgets/qtextedit/tst_qtextedit.cpp

Lines changed: 39 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
Q_LOGGING_CATEGORY(lcTests, "qt.widgets.tests")
3939

4040
//Used in copyAvailable
41-
typedef QPair<Qt::Key, Qt::KeyboardModifier> keyPairType;
41+
using keyPairType = std::pair<Qt::Key, Qt::KeyboardModifier>;
4242
typedef QList<keyPairType> pairListType;
4343
Q_DECLARE_METATYPE(keyPairType);
4444

@@ -1281,71 +1281,79 @@ void tst_QTextEdit::copyAvailable_data()
12811281
QTest::addColumn<QList<bool> >("copyAvailable");
12821282
QTest::addColumn<QString>("function");
12831283

1284-
pairListType keystrokes;
12851284
QList<bool> copyAvailable;
1286-
1287-
keystrokes << qMakePair(Qt::Key_B, Qt::NoModifier) << qMakePair(Qt::Key_B, Qt::NoModifier)
1288-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier);
1285+
pairListType keystrokes = {{Qt::Key_B, Qt::NoModifier},
1286+
{Qt::Key_B, Qt::NoModifier},
1287+
{Qt::Key_Left, Qt::ShiftModifier}};
12891288
copyAvailable << true ;
12901289
QTest::newRow(QString("Case1 B,B, <- + shift | signals: true").toLatin1())
12911290
<< keystrokes << copyAvailable << QString();
12921291

1293-
keystrokes.clear();
12941292
copyAvailable.clear();
12951293

1296-
keystrokes << qMakePair(Qt::Key_T, Qt::NoModifier) << qMakePair(Qt::Key_A, Qt::NoModifier)
1297-
<< qMakePair(Qt::Key_A, Qt::NoModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier);
1294+
keystrokes = {{Qt::Key_T, Qt::NoModifier},
1295+
{Qt::Key_A, Qt::NoModifier},
1296+
{Qt::Key_A, Qt::NoModifier},
1297+
{Qt::Key_Left, Qt::ShiftModifier}};
12981298
copyAvailable << true << false;
12991299
QTest::newRow(QString("Case2 T,A,A, <- + shift, cut() | signals: true, false").toLatin1())
13001300
<< keystrokes << copyAvailable << QString("cut");
13011301

1302-
keystrokes.clear();
13031302
copyAvailable.clear();
13041303

1305-
keystrokes << qMakePair(Qt::Key_T, Qt::NoModifier) << qMakePair(Qt::Key_A, Qt::NoModifier)
1306-
<< qMakePair(Qt::Key_A, Qt::NoModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier)
1307-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier);
1304+
keystrokes = {{Qt::Key_T, Qt::NoModifier},
1305+
{Qt::Key_A, Qt::NoModifier},
1306+
{Qt::Key_A, Qt::NoModifier},
1307+
{Qt::Key_Left, Qt::ShiftModifier},
1308+
{Qt::Key_Left, Qt::ShiftModifier},
1309+
{Qt::Key_Left, Qt::ShiftModifier}};
13081310
copyAvailable << true;
13091311
QTest::newRow(QString("Case3 T,A,A, <- + shift, <- + shift, <- + shift, copy() | signals: true").toLatin1())
13101312
<< keystrokes << copyAvailable << QString("copy");
13111313

1312-
keystrokes.clear();
13131314
copyAvailable.clear();
13141315

1315-
keystrokes << qMakePair(Qt::Key_T, Qt::NoModifier) << qMakePair(Qt::Key_A, Qt::NoModifier)
1316-
<< qMakePair(Qt::Key_A, Qt::NoModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier)
1317-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier)
1318-
<< qMakePair(Qt::Key_X, Qt::ControlModifier);
1316+
keystrokes = {{Qt::Key_T, Qt::NoModifier},
1317+
{Qt::Key_A, Qt::NoModifier},
1318+
{Qt::Key_A, Qt::NoModifier},
1319+
{Qt::Key_Left, Qt::ShiftModifier},
1320+
{Qt::Key_Left, Qt::ShiftModifier},
1321+
{Qt::Key_Left, Qt::ShiftModifier},
1322+
{Qt::Key_X, Qt::ControlModifier}};
13191323
copyAvailable << true << false;
13201324
QTest::newRow(QString("Case4 T,A,A, <- + shift, <- + shift, <- + shift, ctrl + x, paste() | signals: true, false").toLatin1())
13211325
<< keystrokes << copyAvailable << QString("paste");
13221326

1323-
keystrokes.clear();
13241327
copyAvailable.clear();
13251328

1326-
keystrokes << qMakePair(Qt::Key_B, Qt::NoModifier) << qMakePair(Qt::Key_B, Qt::NoModifier)
1327-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier) << qMakePair(Qt::Key_Left, Qt::NoModifier);
1329+
keystrokes = {{Qt::Key_B, Qt::NoModifier},
1330+
{Qt::Key_B, Qt::NoModifier},
1331+
{Qt::Key_Left, Qt::ShiftModifier},
1332+
{Qt::Key_Left, Qt::NoModifier}};
13281333
copyAvailable << true << false;
13291334
QTest::newRow(QString("Case5 B,B, <- + shift, <- | signals: true, false").toLatin1())
13301335
<< keystrokes << copyAvailable << QString();
13311336

1332-
keystrokes.clear();
13331337
copyAvailable.clear();
13341338

1335-
keystrokes << qMakePair(Qt::Key_B, Qt::NoModifier) << qMakePair(Qt::Key_A, Qt::NoModifier)
1336-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier) << qMakePair(Qt::Key_Left, Qt::NoModifier)
1337-
<< qMakePair(Qt::Key_Right, Qt::ShiftModifier);
1339+
keystrokes = {{Qt::Key_B, Qt::NoModifier},
1340+
{Qt::Key_A, Qt::NoModifier},
1341+
{Qt::Key_Left, Qt::ShiftModifier},
1342+
{Qt::Key_Left, Qt::NoModifier},
1343+
{Qt::Key_Right, Qt::ShiftModifier}};
13381344
copyAvailable << true << false << true << false;
13391345
QTest::newRow(QString("Case6 B,A, <- + shift, ->, <- + shift | signals: true, false, true, false").toLatin1())
13401346
<< keystrokes << copyAvailable << QString("cut");
13411347

1342-
keystrokes.clear();
13431348
copyAvailable.clear();
13441349

1345-
keystrokes << qMakePair(Qt::Key_T, Qt::NoModifier) << qMakePair(Qt::Key_A, Qt::NoModifier)
1346-
<< qMakePair(Qt::Key_A, Qt::NoModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier)
1347-
<< qMakePair(Qt::Key_Left, Qt::ShiftModifier) << qMakePair(Qt::Key_Left, Qt::ShiftModifier)
1348-
<< qMakePair(Qt::Key_X, Qt::ControlModifier);
1350+
keystrokes = {{Qt::Key_T, Qt::NoModifier},
1351+
{Qt::Key_A, Qt::NoModifier},
1352+
{Qt::Key_A, Qt::NoModifier},
1353+
{Qt::Key_Left, Qt::ShiftModifier},
1354+
{Qt::Key_Left, Qt::ShiftModifier},
1355+
{Qt::Key_Left, Qt::ShiftModifier},
1356+
{Qt::Key_X, Qt::ControlModifier}};
13491357
copyAvailable << true << false << true;
13501358
QTest::newRow(QString("Case7 T,A,A, <- + shift, <- + shift, <- + shift, ctrl + x, undo() | signals: true, false, true").toLatin1())
13511359
<< keystrokes << copyAvailable << QString("undo");
@@ -2763,13 +2771,13 @@ namespace {
27632771

27642772
void drawTextItem(const QPointF &, const QTextItem &textItem) override
27652773
{
2766-
itemFonts.append(qMakePair(textItem.text(), textItem.font()));
2774+
itemFonts.append({textItem.text(), textItem.font()});
27672775
}
27682776

27692777
Type type() const override { return User; }
27702778

27712779

2772-
QList<QPair<QString, QFont> > itemFonts;
2780+
QList<std::pair<QString, QFont> > itemFonts;
27732781
};
27742782

27752783
class MyPaintDevice : public QPaintDevice

0 commit comments

Comments
 (0)