Simplify code with grep options and less hardcoding #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 8731c51. From man grep(1): -I Process a binary file as if it did not contain matching data; this is equivalent to the --binary-files=without-match
From man grep(1): -d ACTION, --directories=ACTION If an input file is a directory, use ACTION to process it. By default, ACTION is read, i.e., read directories just as if they were ordinary files. If ACTION is skip, silently skip directories. If ACTION is recurse, read all files under each directory, recursively, following symbolic links only if they are on the command line. This is equivalent to the -r option.
Contributor
| Closing due to staleness. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
By using grep's built-in options -I and -d, one can achieve the same goals as are achieved by conditionals and tests in the current code. This eliminates the need for an entire module ("path") and reduces code complexity.
Instead of using a pipe-delimited string and injecting it directly, it is safer and easier for future developers to manipulate a native array of patterns and compose the ORed set using Array.join("|").
Because hardcoded paths were used in multiple locations, DRY (and an aversion to magic values) drive me to create variables for them instead.