Don't ignore comments in .codeclimate.yml #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
maxjacobson force-pushed the mj/dont-ignore-codeclimate-yml-fully branch from 8f937d9 to 9f71aee Compare 
lib/fix-me.js Outdated
| this.find(paths, strings); | ||
| }; | ||
| | ||
| var isItsOwnConfig = function(path, lineNumber) { |
Contributor
There was a problem hiding this comment.
wdyt about a different name for this function?
I find the test description really informative.
WDYT about something like two functions:
isItsOwnConfig && isNotComment or something?
Contributor Author
There was a problem hiding this comment.
Yea I like it - I named slightly differently, but on board with the idea
Contributor
| One idea, up to you. LGTM |
maxjacobson force-pushed the mj/dont-ignore-codeclimate-yml-fully branch from 32e9b67 to 0f15d96 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow-up to #46, inspired by @ABaldwinHunter's comment #46 (comment)