Jacobi007 jk add include paths #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| engines: | ||
| fixme: | ||
| enabled: false | ||
| eslint: | ||
| enabled: true | ||
| Contributor There was a problem hiding this comment. Can you also add our default Contributor Author There was a problem hiding this comment. sure sounds good! | ||
| ratings: | ||
| paths: | ||
| - "**.js" | ||
| exclude_paths: | ||
| - "**/*.md" | ||
| - "Dockerfile" | ||
| - "bin/fixme" | ||
| - "tests/**" | ||
| - ".codeclimate.yml" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,253 @@ | ||
| ecmaFeatures: {} | ||
| rules: | ||
| no-alert: 0 | ||
| no-array-constructor: 0 | ||
| no-bitwise: 0 | ||
| no-caller: 0 | ||
| no-catch-shadow: 0 | ||
| no-class-assign: 0 | ||
| no-cond-assign: 2 | ||
| no-console: 2 | ||
| no-const-assign: 0 | ||
| no-constant-condition: 2 | ||
| no-continue: 0 | ||
| no-control-regex: 2 | ||
| no-debugger: 2 | ||
| no-delete-var: 2 | ||
| no-div-regex: 0 | ||
| no-dupe-keys: 2 | ||
| no-dupe-args: 2 | ||
| no-duplicate-case: 2 | ||
| no-else-return: 0 | ||
| no-empty: 2 | ||
| no-empty-character-class: 2 | ||
| no-empty-label: 0 | ||
| no-eq-null: 0 | ||
| no-eval: 0 | ||
| no-ex-assign: 2 | ||
| no-extend-native: 0 | ||
| no-extra-bind: 0 | ||
| no-extra-boolean-cast: 2 | ||
| no-extra-parens: 0 | ||
| no-extra-semi: 2 | ||
| no-fallthrough: 2 | ||
| no-floating-decimal: 0 | ||
| no-func-assign: 2 | ||
| no-implicit-coercion: 0 | ||
| no-implied-eval: 0 | ||
| no-inline-comments: 0 | ||
| no-inner-declarations: | ||
| - 2 | ||
| - functions | ||
| no-invalid-regexp: 2 | ||
| no-invalid-this: 0 | ||
| no-irregular-whitespace: 2 | ||
| no-iterator: 0 | ||
| no-label-var: 0 | ||
| no-labels: 0 | ||
| no-lone-blocks: 0 | ||
| no-lonely-if: 0 | ||
| no-loop-func: 0 | ||
| no-mixed-requires: | ||
| - 0 | ||
| - false | ||
| no-mixed-spaces-and-tabs: | ||
| - 2 | ||
| - false | ||
| linebreak-style: | ||
| - 0 | ||
| - unix | ||
| no-multi-spaces: 0 | ||
| no-multi-str: 0 | ||
| no-multiple-empty-lines: | ||
| - 0 | ||
| - max: 2 | ||
| no-native-reassign: 0 | ||
| no-negated-in-lhs: 2 | ||
| no-nested-ternary: 0 | ||
| no-new: 0 | ||
| no-new-func: 0 | ||
| no-new-object: 0 | ||
| no-new-require: 0 | ||
| no-new-wrappers: 0 | ||
| no-obj-calls: 2 | ||
| no-octal: 2 | ||
| no-octal-escape: 0 | ||
| no-param-reassign: 0 | ||
| no-path-concat: 0 | ||
| no-plusplus: 0 | ||
| no-process-env: 0 | ||
| no-process-exit: 0 | ||
| no-proto: 0 | ||
| no-redeclare: 2 | ||
| no-regex-spaces: 2 | ||
| no-reserved-keys: 0 | ||
| no-restricted-modules: 0 | ||
| no-return-assign: 0 | ||
| no-script-url: 0 | ||
| no-self-compare: 0 | ||
| no-sequences: 0 | ||
| no-shadow: 0 | ||
| no-shadow-restricted-names: 0 | ||
| no-spaced-func: 0 | ||
| no-sparse-arrays: 2 | ||
| no-sync: 0 | ||
| no-ternary: 0 | ||
| no-trailing-spaces: 0 | ||
| no-this-before-super: 0 | ||
| no-throw-literal: 0 | ||
| no-undef: 2 | ||
| no-undef-init: 0 | ||
| no-undefined: 0 | ||
| no-unexpected-multiline: 0 | ||
| no-underscore-dangle: 0 | ||
| no-unneeded-ternary: 0 | ||
| no-unreachable: 2 | ||
| no-unused-expressions: 0 | ||
| no-unused-vars: | ||
| - 2 | ||
| - vars: all | ||
| args: after-used | ||
| no-use-before-define: 0 | ||
| no-useless-call: 0 | ||
| no-void: 0 | ||
| no-var: 0 | ||
| no-warning-comments: | ||
| - 0 | ||
| - terms: | ||
| - todo | ||
| - fixme | ||
| - xxx | ||
| location: start | ||
| no-with: 0 | ||
| array-bracket-spacing: | ||
| - 0 | ||
| - never | ||
| arrow-parens: 0 | ||
| arrow-spacing: 0 | ||
| accessor-pairs: 0 | ||
| block-scoped-var: 0 | ||
| brace-style: | ||
| - 0 | ||
| - 1tbs | ||
| callback-return: 0 | ||
| camelcase: 0 | ||
| comma-dangle: | ||
| - 2 | ||
| - never | ||
| comma-spacing: 0 | ||
| comma-style: 0 | ||
| complexity: | ||
| - 2 | ||
| - 11 | ||
| computed-property-spacing: | ||
| - 0 | ||
| - never | ||
| consistent-return: 0 | ||
| consistent-this: | ||
| - 0 | ||
| - that | ||
| constructor-super: 0 | ||
| curly: | ||
| - 0 | ||
| - all | ||
| default-case: 0 | ||
| dot-location: 0 | ||
| dot-notation: | ||
| - 0 | ||
| - allowKeywords: true | ||
| eol-last: 0 | ||
| eqeqeq: 0 | ||
| func-names: 0 | ||
| func-style: | ||
| - 0 | ||
| - declaration | ||
| generator-star-spacing: 0 | ||
| guard-for-in: 0 | ||
| handle-callback-err: 0 | ||
| indent: 0 | ||
| init-declarations: 0 | ||
| key-spacing: | ||
| - 0 | ||
| - beforeColon: false | ||
| afterColon: true | ||
| lines-around-comment: 0 | ||
| max-depth: | ||
| - 0 | ||
| - 4 | ||
| max-len: | ||
| - 0 | ||
| - 80 | ||
| - 4 | ||
| max-nested-callbacks: | ||
| - 0 | ||
| - 2 | ||
| max-params: | ||
| - 0 | ||
| - 3 | ||
| max-statements: | ||
| - 0 | ||
| - 10 | ||
| new-cap: 0 | ||
| new-parens: 0 | ||
| newline-after-var: 0 | ||
| object-curly-spacing: | ||
| - 0 | ||
| - never | ||
| object-shorthand: 0 | ||
| one-var: 0 | ||
| operator-assignment: | ||
| - 0 | ||
| - always | ||
| operator-linebreak: 0 | ||
| padded-blocks: 0 | ||
| prefer-const: 0 | ||
| prefer-spread: 0 | ||
| prefer-reflect: 0 | ||
| quote-props: 0 | ||
| quotes: | ||
| - 0 | ||
| - double | ||
| radix: 0 | ||
| require-yield: 0 | ||
| semi: 0 | ||
| semi-spacing: | ||
| - 0 | ||
| - before: false | ||
| after: true | ||
| sort-vars: 0 | ||
| space-after-keywords: | ||
| - 0 | ||
| - always | ||
| space-before-blocks: | ||
| - 0 | ||
| - always | ||
| space-before-function-paren: | ||
| - 0 | ||
| - always | ||
| space-in-parens: | ||
| - 0 | ||
| - never | ||
| space-infix-ops: 0 | ||
| space-return-throw-case: 0 | ||
| space-unary-ops: | ||
| - 0 | ||
| - words: true | ||
| nonwords: false | ||
| spaced-comment: 0 | ||
| strict: 0 | ||
| use-isnan: 2 | ||
| valid-jsdoc: 0 | ||
| valid-typeof: 2 | ||
| vars-on-top: 0 | ||
| wrap-iife: 0 | ||
| wrap-regex: 0 | ||
| yoda: | ||
| - 0 | ||
| - never | ||
| env: | ||
| browser: true | ||
| node: true | ||
| jquery: true | ||
| amd: true | ||
| commonjs: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #!/usr/bin/env node | ||
| | ||
| var FixMe = require('../lib/fix-me'); | ||
| var fixMe = new FixMe(); | ||
| | ||
| fixMe.runEngine(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be!
Enabling seemed to require excluding the main files of the project (because they have the name
Fixmepeppered throughout), so ESLint seemed more valuable to me.I can revert and/or think about a way to avoid false positives from Fixme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. I think engine-specific exclude_paths are in the works.
This seems like an excellent use case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh hah yeah let's leave it off for now