Jacobi007 jk add include paths

[ABaldwinHunter]

resolved merge conflicts to incorporate changes from https://github.com/jacobi007/codeclimate-fixme/tree/jk-add-include-paths

• Makes Fixme engine accept include_paths

@codeclimat/review

[gdiggs]

I believe this repo has automated tests now, can you add some?

[gdiggs]

What do you think of putting this in its own module and requiring it at the top of the file?

[gdiggs]

Would be something like this (I think):

// diff.js module.exports = function(a1, a2) { ... }; // index.js var diff = require("diff");

[ABaldwinHunter]

sounds good! Adding tests too ...

[ABaldwinHunter]

@codeclimate/review @gordondiggs

Ready for another look!

Main changes:

• Makes fixme engine use include paths
• adds testing suite with mocha and chai, integrated with circle. One real spec, a few pending
• refactors the Fixme code from one large file into a couple of smaller files. This change makes the code more readable and makes it easier to package the tooling in future.

The circle build runs tests! https://circleci.com/gh/codeclimate/codeclimate-fixme/35

[ABaldwinHunter]

It also does some renaming of files, and updates the .codeclimate.yml to use eslint.

*Adding tests feels important, but it felt like a large enough change to add the main suite and structure. We can make tests more robust in separate PR.

[ABaldwinHunter]

P.S. I can also squash commit history if preferred.

[gdiggs]

I think generally all filenames should be underscored (but the variable name looks good)

[gdiggs]

Minor CC nits but LGTM! I think it might be good to squash the commits before you merge.

[ABaldwinHunter]

@gordondiggs thanks for the feedback! I added .eslintrc.

I also added a few things to our package.json. Could you take another look when you have a moment?

new stuff

 "main": "./lib/fix-me.js", }, "files": [ "LICENSE", "README.md", "bin", "lib" ], "repository": { "type": "git", "url": "https://github.com/codeclimate/codeclimate-fixme" }, "keywords": [ "fixme", "codeclimate" ], "engines": { "node": ">=0.10" }, "license": "MIT" 

If those changes look okay, I'll go ahead and squash commits.

[gdiggs]

Our default file is much bigger. What made you go with this?

[ABaldwinHunter]

Oh cool. Updated.

I originally tried to mimic https://github.com/codeclimate/codeclimate-eslint/blob/master/.eslintrc

[ABaldwinHunter]

I can update that one to match after

[gdiggs]

Ah yeah that one needs to be changed

[gdiggs]

LGTM