Replace isVisible implementation

Summary: Current isVisible implementation calls testmanagerd and at some conditions holds for over 60s. Since isVisible is pretty common call at times this can be really problematic. This implementation is based on frame intersection and hitpoint checking. In performance of both approaches is firmly similar, correctness looks the same as well. However, hitpoint does make connection to testmanagerd as well so it may have same issues as isVisible querry. Because isVisible was only call that caused the problem we have a good chance of fixing it, so let's try. Reviewed By: lawrencelomax Differential Revision: D4762527 fbshipit-source-id: 49f3b140a923877be5fea04a168f1b69d6084b01

Author: Marek Cirkos

PrivateHeaders/XCTest/XCElementSnapshot.h

@@ -69,7 +69,7 @@
 - (id)_uniquelyIdentifyingSwiftCode;
 - (BOOL)_isAncestorOfElement:(id)arg1;
 - (BOOL)_isDescendantOfElement:(id)arg1;
-- (id)_rootElement;
+- (XCElementSnapshot *)_rootElement;
 - (BOOL)_frameFuzzyMatchesElement:(id)arg1;
 - (BOOL)_fuzzyMatchesElement:(id)arg1;
 - (BOOL)_matchesElement:(id)arg1;

WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m

@@ -9,8 +9,13 @@
 
 #import "XCUIElement+FBIsVisible.h"
 
+#import "FBApplication.h"
+#import "FBConfiguration.h"
+#import "FBMathUtils.h"
 #import "XCElementSnapshot+FBHelpers.h"
 #import "XCTestPrivateSymbols.h"
+#import <XCTest/XCUIDevice.h>
+
 
 @implementation XCUIElement (FBIsVisible)
 
@@ -29,18 +34,17 @@ @implementation XCElementSnapshot (FBIsVisible)
 - (BOOL)fb_isVisible
 {
  if (CGRectIsEmpty(self.frame) || CGRectIsEmpty(self.visibleFrame)) {
- /*
- It turns out, that XCTest triggers
- Enqueue Failure: UI Testing Failure - Failure fetching attributes for element
- <XCAccessibilityElement: 0x60000025f9e0> Device element: Error Domain=XCTestManagerErrorDomain Code=13
- "Error copying attributes -25202" UserInfo={NSLocalizedDescription=Error copying attributes -25202} <unknown> 0 1
- error in the log if we try to get visibility attribute for an element snapshot, which does not intersect with visible appication area
- or if it has zero width/height. Also, XCTest waits for 15 seconds after this line appears in the log, which makes /source command
- execution extremely slow for some applications.
- */
  return NO;
  }
- return [(NSNumber *)[self fb_attributeValue:FB_XCAXAIsVisibleAttribute] boolValue];
+ if ([FBConfiguration shouldUseTestManagerForVisibilityDetection]) {
+ return [(NSNumber *)[self fb_attributeValue:FB_XCAXAIsVisibleAttribute] boolValue];
+ }
+ XCElementSnapshot *app = [self _rootElement];
+ CGSize screenSize = FBAdjustDimensionsForApplication(app.frame.size, (UIInterfaceOrientation)[XCUIDevice sharedDevice].orientation);
+ CGRect screenFrame = CGRectMake(0, 0, screenSize.width, screenSize.height);
+ BOOL rectIntersects = CGRectIntersectsRect(self.visibleFrame, screenFrame);
+ BOOL isActionable = CGRectContainsPoint(screenFrame, self.hitPoint);
+ return rectIntersects && isActionable;
 }
 
 @end

WebDriverAgentLib/Commands/FBSessionCommands.m

@@ -10,6 +10,7 @@
 #import "FBSessionCommands.h"
 
 #import "FBApplication.h"
+#import "FBConfiguration.h"
 #import "FBRouteRequest.h"
 #import "FBSession.h"
 #import "FBApplication.h"
@@ -66,6 +67,8 @@ + (NSArray *)routes
  if (!bundleID) {
  return FBResponseWithErrorFormat(@"'bundleId' desired capability not provided");
  }
+ [FBConfiguration setShouldUseTestManagerForVisibilityDetection:[requirements[@"shouldUseTestManagerForVisibilityDetection"] boolValue]];
+
  FBApplication *app = [[FBApplication alloc] initPrivateWithPath:appPath bundleID:bundleID];
  app.fb_shouldWaitForQuiescence = [requirements[@"shouldWaitForQuiescence"] boolValue];
  app.launchArguments = (NSArray<NSString *> *)requirements[@"arguments"] ?: @[];

WebDriverAgentLib/Utilities/FBConfiguration.h

@@ -16,6 +16,9 @@ NS_ASSUME_NONNULL_BEGIN
  */
 @interface FBConfiguration : NSObject
 
+/*! If set to YES will ask TestManagerDaemon for element visibility */
+@property (class, nonatomic, assign) BOOL shouldUseTestManagerForVisibilityDetection;
+
 /**
  Switch for enabling/disabling reporting fake collection view cells by Accessibility framework.
  If set to YES it will report also invisible cells.

WebDriverAgentLib/Utilities/FBConfiguration.m

@@ -19,6 +19,8 @@
 static NSUInteger const DefaultStartingPort = 8100;
 static NSUInteger const DefaultPortRange = 100;
 
+static BOOL FBShouldUseTestManagerForVisibilityDetection = NO;
+
 @implementation FBConfiguration
 
 #pragma mark Public
@@ -48,6 +50,16 @@ + (BOOL)verboseLoggingEnabled
  return [NSProcessInfo.processInfo.environment[@"VERBOSE_LOGGING"] boolValue];
 }
 
++ (void)setShouldUseTestManagerForVisibilityDetection:(BOOL)value
+{
+ FBShouldUseTestManagerForVisibilityDetection = value;
+}
+
++ (BOOL)shouldUseTestManagerForVisibilityDetection
+{
+ return FBShouldUseTestManagerForVisibilityDetection;
+}
+
 #pragma mark Private
 
 + (NSRange)bindingPortRangeFromArguments