Skip to content

Commit 166f4b1

Browse files
authored
Merge pull request ej2#145 from chandeeland/detail-line-typos
Some DetailLine.DetailType strings were misspelled
2 parents 5264cf7 + 0799a6a commit 166f4b1

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

quickbooks/objects/detailline.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class SubtotalLine(DetailLine):
8585

8686
def __init__(self):
8787
super(SubtotalLine, self).__init__()
88-
self.DetailType = "SubtotalLineDetail"
88+
self.DetailType = "SubTotalLineDetail"
8989
self.SubtotalLineDetail = None
9090

9191

@@ -160,8 +160,8 @@ class GroupLine(DetailLine):
160160

161161
def __init__(self):
162162
super(GroupLine, self).__init__()
163-
self.DetailType = "SalesItemLineDetail"
164-
self.SalesItemLineDetail = None
163+
self.DetailType = "GroupLineDetail"
164+
self.GroupLineDetail = None
165165

166166

167167
class DescriptionOnlyLine(DetailLine):
@@ -171,7 +171,7 @@ class DescriptionOnlyLine(DetailLine):
171171

172172
def __init__(self):
173173
super(DescriptionOnlyLine, self).__init__()
174-
self.DetailType = "DescriptionLineDetail"
174+
self.DetailType = "DescriptionOnly"
175175
self.DescriptionLineDetail = None
176176

177177

tests/unit/objects/test_detailline.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class SubtotalLineTest(unittest.TestCase):
5252
def test_init(self):
5353
subtotal_line = SubtotalLine()
5454

55-
self.assertEquals(subtotal_line.DetailType, "SubtotalLineDetail")
55+
self.assertEquals(subtotal_line.DetailType, "SubTotalLineDetail")
5656
self.assertEquals(subtotal_line.SubtotalLineDetail, None)
5757

5858

@@ -92,8 +92,8 @@ class GroupLineTest(unittest.TestCase):
9292
def test_init(self):
9393
line = GroupLine()
9494

95-
self.assertEquals(line.DetailType, "SalesItemLineDetail")
96-
self.assertEquals(line.SalesItemLineDetail, None)
95+
self.assertEquals(line.DetailType, "GroupLineDetail")
96+
self.assertEquals(line.GroupLineDetail, None)
9797

9898

9999
class ItemBasedExpenseLineDetailTest(unittest.TestCase):
@@ -132,5 +132,5 @@ class DescriptionOnlyLineTests(unittest.TestCase):
132132
def test_unicode(self):
133133
line = DescriptionOnlyLine()
134134

135-
self.assertEquals(line.DetailType, "DescriptionLineDetail")
135+
self.assertEquals(line.DetailType, "DescriptionOnly")
136136
self.assertEquals(line.DescriptionLineDetail, None)

0 commit comments

Comments
 (0)