-
- Notifications
You must be signed in to change notification settings - Fork 33.4k
bpo-32222: Fix pygettext skipping docstrings for funcs with arg typehints #4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka merged 15 commits into python:master from Tobotimus:32222-fix-pygettext-annotations Feb 26, 2018
Merged
Changes from 1 commit
Commits
Show all changes
15 commits Select commit Hold shift + click to select a range
00405d2 Fix pygettext skipping docstrings for funcs with arg typehints
Tobotimus 09abc0e Add news entry
Tobotimus bcbfd74 Revert unwanted accidental changes
Tobotimus 7f5d2c7 Revert accidental encoding change
Tobotimus eb2267b Skip over nested parens in param list
Tobotimus 6633e80 Properly reset paren count to zero
Tobotimus 7e974fa Add tests
Tobotimus 30cc30d Refactor logic
Tobotimus 36779af Removing trailing whitespace
Tobotimus cd6ea5c Fix whitespace
Tobotimus 038d01c Add tests for class
Tobotimus cf12715 Funcs and classes use same logic
Tobotimus 2f3dbf5 One integer count for all enclosures
Tobotimus fc0f1ea Update news entry
Tobotimus 8c633ff Update news entry v2
Tobotimus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -5,7 +5,7 @@ | |
| # Minimally patched to make it even more xgettext compatible | ||
| # by Peter Funk <pf@artcom-gmbh.de> | ||
| # | ||
| # 2002-11-22 J�rgen Hermann <jh@web.de> | ||
| # 2002-11-22 J�rgen Hermann <jh@web.de> | ||
| # Added checks that _() only contains string literals, and | ||
| # command line args are resolved to module lists, i.e. you | ||
| # can now pass a filename, a module or package name, or a | ||
| | @@ -208,7 +208,7 @@ def make_escapes(pass_nonascii): | |
| global escapes, escape | ||
| if pass_nonascii: | ||
| # Allow non-ascii characters to pass through so that e.g. 'msgid | ||
| # "H�he"' would result not result in 'msgid "H\366he"'. Otherwise we | ||
| # "H�he"' would result not result in 'msgid "H\366he"'. Otherwise we | ||
| # escape any character outside the 32..126 range. | ||
| mod = 128 | ||
| escape = escape_ascii | ||
| | @@ -340,13 +340,21 @@ def __waiting(self, ttype, tstring, lineno): | |
| elif ttype not in (tokenize.COMMENT, tokenize.NL): | ||
| self.__freshmodule = 0 | ||
| return | ||
| # class docstring? | ||
| if ttype == tokenize.NAME and tstring in ('class', 'def'): | ||
| self.__state = self.__suiteseen | ||
| # class or func/method docstring? | ||
| if ttype == tokenize.NAME: | ||
| if tstring == 'def': | ||
| self.__state = self.__funcseen | ||
| elif tstring == 'class': | ||
| self.__state = self.__suiteseen | ||
| return | ||
| if ttype == tokenize.NAME and tstring in opts.keywords: | ||
| self.__state = self.__keywordseen | ||
| | ||
| def __funcseen(self, ttype, tstring, lineno): | ||
| # ignore anything until we see the closing parenthesis | ||
| if ttype == tokenize.OP and tstring == ')': | ||
| ||
| self.__state = self.__suiteseen | ||
| | ||
| def __suiteseen(self, ttype, tstring, lineno): | ||
| # ignore anything until we see the colon | ||
| if ttype == tokenize.OP and tstring == ':': | ||
| | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unwanted changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now reverted.