Skip to content

bpo-41123: Remove Py_UNICODE_COPY() and Py_UNICODE_FILL() #28887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

bpo-41123: Remove Py_UNICODE_COPY() and Py_UNICODE_FILL() #28887

merged 1 commit into from
Oct 11, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 11, 2021 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

These functions are not listed in these PEPs:
@vstinner
Copy link
Member Author

Py_UNICODE_COPY() and Py_UNICODE_FILL() are no longer used in the PyPI top 5000 projects:

$ ./search_pypi_top_5000.sh Py_UNICODE_COPY pypi-top-5000_2021-08-17/pipenv-2021.5.29.tar.gz pypi-top-5000_2021-08-17/Genshi-0.7.5.tar.gz pypi-top-5000_2021-08-17/frozendict-2.0.6.tar.gz
  • pipenv-2021.5.29.tar.gz: pipenv/vendor/markupsafe/_speedups.c is not affected, Py_UNICODE_COPY() is only used on Python 2.7
  • Genshi-0.7.5.tar.gz is not affected, Py_UNICODE_COPY() is only used on Python 3.2 and older
  • frozendict-2.0.6.tar.gz is not affected, it contains raw copies of unicodeobject.h header file, it doesn't call Py_UNICODE_COPY().
$ ./search_pypi_top_5000.sh Py_UNICODE_FILL pypi-top-5000_2021-08-17/frozendict-2.0.6.tar.gz
  • frozendict-2.0.6.tar.gz is not affected, it contains raw copies of unicodeobject.h header file, it doesn't call Py_UNICODE_FILL().
@vstinner vstinner merged commit 1f316ea into python:main Oct 11, 2021
@vstinner vstinner deleted the remove_py_unicode branch October 11, 2021 21:36
@vstinner
Copy link
Member Author

cc @methane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot