[3.8] bpo-42536: GC track recycled tuples (GH-23623) #23652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Several built-in and standard library types now ensure that their internal result tuples are always tracked by the garbage collector: - collections.OrderedDict.items - dict.items - enumerate - functools.reduce - itertools.combinations - itertools.combinations_with_replacement - itertools.permutations - itertools.product - itertools.zip_longest - zip Previously, they could have become untracked by a prior garbage collection. (cherry picked from commit 226a012)
| Not sure what's up with Travis. It looks like it's using an old (perhaps 3.5 system python?) |
| I know Travis has been problematic in the past. I see this same failure on several other recent 3.8 backports as well, so I think it can safely be ignored here. (I'll go ahead and open an issue for it, though.) |
|
pablogsal approved these changes Dec 7, 2020
Yeah, let's track that issue separately |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CC @pablogsal, just to make sure I'm doing the manual backport with
cherry_pickercorrectly (automatic backporting failed).Several built-in and standard library types now ensure that their internal result tuples are always tracked by the garbage collector:
Previously, they could have become untracked by a prior garbage collection.
(cherry picked from commit 226a012)
https://bugs.python.org/issue42536