-
- Notifications
You must be signed in to change notification settings - Fork 33.3k
bpo-38200: Add itertools.pairwise() #23549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. Needed documentation, tests, and implementation of __reduce__.
| I'm intending to leave out
|
| Greetings. It's exciting to see new tools added to the Standard Library. Since If a more general tool is needed (e.g. one that applies to iterators), then I think it's worth generalizing the window size as well. I understand the topic of sliding-windows has been discussed in the past, but that was prior to officially adopting a windowing tool like Many thanks. |
| Hi @pylang — python-dev does not use pull requests for design discussions, only code reviews. |
This is a first draft. Needs more thought on refcnts. Needs docs, tests, and a better doctstring.
https://bugs.python.org/issue38200