Skip to content

bpo-35293: Remove RemovedInSphinx40Warning #22198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2020
Merged

bpo-35293: Remove RemovedInSphinx40Warning #22198

merged 3 commits into from
Sep 18, 2020
+22 −15

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Sep 11, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner September 11, 2020 11:42
@corona10
Copy link
Member Author

corona10 commented Sep 11, 2020

The current failure is not related to this PR
See: https://bugs.python.org/issue41762

/Users/corona10/oss/cpython/Doc/library/string.rst:311:duplicate token description of sign, other instance in library/functions
@vstinner
Copy link
Member

vstinner commented Sep 11, 2020

The current failure is not related to this PR

I don't understand. All jobs are now green. Did you re-run some jobs?
@corona10
Copy link
Member Author

corona10 commented Sep 11, 2020 •
edited
Loading

I don't understand. All jobs are now green.

I expected that Travis CI - Pull Request will failed but not on this PR.
@corona10 corona10 changed the title bpo-35293: Remove PyModulelevel deprecated warning bpo-35293: Remove RemovedInSphinx40Warning Sep 12, 2020
@corona10 corona10 requested a review from njsmith September 12, 2020 08:52
@corona10
Copy link
Member Author

corona10 commented Sep 12, 2020

@vstinner @njsmith Please take a look
@terryjreedy terryjreedy removed their request for review September 16, 2020 12:23
@corona10 corona10 closed this Sep 17, 2020
@corona10 corona10 reopened this Sep 17, 2020
@corona10 corona10 closed this Sep 18, 2020
@corona10 corona10 reopened this Sep 18, 2020
@vstinner
Copy link
Member

vstinner commented Sep 18, 2020

I fixed https://bugs.python.org/issue41762 with commit 8af239e, PR #22281.
@corona10
Copy link
Member Author

corona10 commented Sep 18, 2020

I fixed https://bugs.python.org/issue41762 with commit 8af239e, PR #22281.

Nice!, I rebased it!
@vstinner
Copy link
Member

vstinner commented Sep 18, 2020

I confirm that the PR fix RemovedInSphinx40Warning warnings.

Without the PR:

$ cd Doc $ make clean $ make venv PYTHON=../python && make html SPHINXOPTS="-j10" (...) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:304: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:316: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableFunction'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:310: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyCoroutineMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:322: RemovedInSphinx40Warning: PyClassmember is deprecated. Please check the implementation of <class 'pyspecific.PyAwaitableMethod'> return PyClassmember.run(self) /home/vstinner/python/master/Doc/tools/extensions/pyspecific.py:278: RemovedInSphinx40Warning: PyModulelevel is deprecated. Please check the implementation of <class 'pyspecific.PyDecoratorFunction'> return PyModulelevel.run(self)

With the PR, I don't see these warnings anymore:

$ cd Doc $ make clean $ make venv PYTHON=../python && make html SPHINXOPTS="-j10" (...)
vstinner
vstinner reviewed Sep 18, 2020
View reviewed changes
vstinner
vstinner approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@corona10 corona10 merged commit 6595cb0 into python:master Sep 18, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Sep 18, 2020

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2020
@corona10 @miss-islington
bpo-35293: Remove RemovedInSphinx40Warning (pythonGH-22198)
50a0af8 
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2020

GH-22302 is a backport of this pull request to the 3.9 branch.
@corona10
Copy link
Member Author

corona10 commented Sep 18, 2020

@vstinner Thank you Victor!
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2020
@corona10 @miss-islington
bpo-35293: Remove RemovedInSphinx40Warning (pythonGH-22198)
d3277da 
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2020

GH-22303 is a backport of this pull request to the 3.8 branch.
@corona10 corona10 deleted the bpo-35293 branch September 18, 2020 09:23
miss-islington added a commit that referenced this pull request Sep 18, 2020
@miss-islington @corona10
bpo-35293: Remove RemovedInSphinx40Warning (GH-22198)
b7cdea8 
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Sep 18, 2020
@miss-islington @corona10
bpo-35293: Remove RemovedInSphinx40Warning (GH-22198)
f3e0ece 
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@corona10 @vstinner
bpo-35293: Remove RemovedInSphinx40Warning (pythonGH-22198)
0d62932 
* bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@corona10 @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni