Skip to content

Conversation

@vsajip
Copy link
Member

@vsajip vsajip commented Feb 15, 2020

Support for Unicode characters in package names and attributes has been improved by changing the regular expression used for matching.

https://bugs.python.org/issue12915

@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #18517 into master will increase coverage by 0.99%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #18517 +/- ## =========================================== + Coverage 82.20% 83.20% +0.99%  =========================================== Files 1958 1571 -387 Lines 589739 414744 -174995 Branches 44456 44457 +1 =========================================== - Hits 484793 345086 -139707  + Misses 95287 60012 -35275  + Partials 9659 9646 -13 
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-12.86%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Lib/dbm/__init__.py 66.66% <0.00%> (-4.45%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.87%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 432 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed6161...698895a. Read the comment docs.

@vsajip vsajip merged commit 4f17c5c into python:master Feb 28, 2020
@vsajip vsajip deleted the fix-12915 branch February 28, 2020 14:26
@aixtools
Copy link
Contributor

Starting with this merge AIX bot fails with:

ERROR: test_name_resolution (test.test_pkgutil.PkgutilTests)

Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/test/test_pkgutil.py", line 249, in test_name_resolution
os.makedirs(d, exist_ok=True)
File "/home/buildbot/buildarea/3.x.aixtools-aix-power6/build/Lib/os.py", line 223, in makedirs
mkdir(name, mode)
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 17-19: ordinal not in range(256)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants