Skip to content

[3.6] bpo-30225: Fix is_valid_fd() on macOS Tiger (#1443) #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2017
Merged

[3.6] bpo-30225: Fix is_valid_fd() on macOS Tiger (#1443) #1449

merged 1 commit into from
May 4, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 4, 2017

is_valid_fd() now uses fstat() instead of dup() on macOS to return 0
on a pipe when the other side of the pipe is closed. fstat() fails
with EBADF in that case, whereas dup() succeed.
(cherry picked from commit 1c4670e)
@vstinner
bpo-30225: Fix is_valid_fd() on macOS Tiger (#1443)
45e57aa 
is_valid_fd() now uses fstat() instead of dup() on macOS to return 0 on a pipe when the other side of the pipe is closed. fstat() fails with EBADF in that case, whereas dup() succeed. (cherry picked from commit 1c4670e)
@vstinner vstinner merged commit 31906b4 into python:3.6 May 4, 2017
@vstinner vstinner deleted the valid_fd_36 branch May 4, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vstinner @the-knights-who-say-ni