gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL #140288
Conversation
| Please merge #140298 first. |
johnslavik requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners 
| # Isolated mode implies -E, -P and -s, purifies sys.path and ignores PYTHON* | ||
| # variables. | ||
| if isolated: | ||
| cmd_line.append('-I') |
There was a problem hiding this comment.
To reuse this routine and spawn_asyncio_repl below, we need to have a knob to not pass -I since that ignores PYTHONSTARTUP completely.
The asyncio REPL currently doesn't comply to that, which is a separate issue I'll report having learnt this.
| def test_asyncio_repl_reaches_python_startup_script(self): | ||
| with os_helper.temp_dir() as tmpdir: | ||
| script = os.path.join(tmpdir, "pythonstartup.py") | ||
| with open(script, "w") as f: | ||
| f.write("print('pythonstartup done!')" + os.linesep) | ||
| f.write("exit(0)" + os.linesep) | ||
| | ||
| env = os.environ.copy() | ||
| env["PYTHON_HISTORY"] = os.path.join(tmpdir, ".asyncio_history") | ||
| env["PYTHONSTARTUP"] = script | ||
| subprocess.check_call( | ||
| [sys.executable, "-m", "asyncio"], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, | ||
| env=env, | ||
| timeout=SHORT_TIMEOUT, | ||
| ) |
There was a problem hiding this comment.
Covered by TestPythonStartup now, so not needed here.
johnslavik left a comment
johnslavik left a comment There was a problem hiding this comment.
I'm also thinking that ideally we would test stdout and stderr separately.
| This is likely it. I can't think of anything simpler but equally complete at the same time. We can abstract as needed in the future. We could use some regexes. |
| self.assertEqual(traceback_lines, expected_lines) | ||
| | ||
| | ||
| @support.force_not_colorized_test_class |
There was a problem hiding this comment.
I'm not sure this is needed, but I think it's OK to keep it as is.
| It seems that the asyncio REPL on Windows leaks the event loop: Definitely a bug, we'll track it elsewhere soon. EDIT: Tracking in #141262 |
johnslavik force-pushed the asyncio-repl-handle-python-startup branch from b85a31b to 0a50a50 Compare 1 participant
This is generally a work in progress; tests are needed.
The asyncio patch is simple and ready.
PYTHONSTARTUPexceptions #140287