bpo-25068: urllib.request.ProxyHandler now lowercases the dict keys #13489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BoboTiG approved these changes May 28, 2019
Contributor
BoboTiG left a comment
BoboTiG left a comment There was a problem hiding this comment.
Thanks @ZackerySpytz, LGTM :)
tirkarthi reviewed May 28, 2019
| assert hasattr(proxies, 'keys'), "proxies must be a mapping" | ||
| self.proxies = proxies | ||
| for type, url in proxies.items(): | ||
| type = type.lower() |
Member
There was a problem hiding this comment.
Is it worth adding this behavior change in https://docs.python.org/3/library/urllib.request.html#urllib.request.ProxyHandler with a versionchanged directive note?
Contributor Author
There was a problem hiding this comment.
For what it's worth, I don't think that this change needs to be documented, but it would be nice to see what a core dev thinks.
Contributor
| Thanks @ZackerySpytz for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
| GH-16107 is a backport of this pull request to the 3.8 branch. |
miss-islington added a commit that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue25068